Skip to content

Dispose HttpClient and Stream in AddPackageParser #41490

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Dispose HttpClient and Stream in AddPackageParser #41490

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3b6748c
Dispose HttpClient and Stream in AddPackageParser
omajid Jun 7, 2024
1ac1e56
Fix typo
akoeplinger Jun 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion src/Cli/dotnet/commands/dotnet-add/dotnet-add-package/AddPackageParser.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,7 @@ private static CliCommand ConstructCommand()

public static IEnumerable<string> QueryNuGet(string match)
{
var httpClient = new HttpClient();
using var httpClient = new HttpClient();

Stream result;

Expand All @@ -104,6 +104,8 @@ public static IEnumerable<string> QueryNuGet(string match)
{
yield return packageId;
}

result.Dispose();
}

internal static IEnumerable<string> EnumerablePackageIdFromQueryResponse(Stream result)
Expand Down