Skip to content

Publish Roslyn Framework Toolset package as part of SDK #39743

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Mar 26, 2024
Merged

Publish Roslyn Framework Toolset package as part of SDK #39743

merged 3 commits into from
Mar 26, 2024

Conversation

@jjonescz
Copy link
Member

@jjonescz jjonescz commented Mar 25, 2024 •
edited
Loading

@ghost ghost added Area-Infrastructure untriaged Request triage from a team member labels Mar 25, 2024
@jjonescz jjonescz force-pushed the roslyn72672-PublishFrameworkToolset branch from d26c3e6 to 205ad43 Compare March 25, 2024 13:34
@jjonescz jjonescz force-pushed the roslyn72672-PublishFrameworkToolset branch from 205ad43 to dad5548 Compare March 25, 2024 15:14
@jjonescz jjonescz marked this pull request as ready for review March 25, 2024 17:32
@jaredpar
Copy link
Member

jaredpar commented Mar 25, 2024

@baronfel

@baronfel baronfel requested a review from a team March 25, 2024 18:01
baronfel
baronfel approved these changes Mar 25, 2024
View reviewed changes
Copy link
Member

@baronfel baronfel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM - I tested locally and it does what it says on the tin. We could merge and start checking installer outputs.

@baronfel
Copy link
Member

baronfel commented Mar 25, 2024

@jjonescz can you solve conflicts? Happy to merge after that.

@jjonescz jjonescz enabled auto-merge (squash) March 26, 2024 08:20
@jjonescz
Copy link
Member Author

jjonescz commented Mar 26, 2024

Unfortunately an unrelated test (CanSortByDownloadCountAndThenByName) started failing now (it's failing in all other PRs as well)

@baronfel
Copy link
Member

baronfel commented Mar 26, 2024

I'm working on backports to skip that test until we can fix it up

@jjonescz jjonescz merged commit 979ffe7 into dotnet:main Mar 26, 2024
@jjonescz jjonescz deleted the roslyn72672-PublishFrameworkToolset branch March 26, 2024 20:06
@jjonescz jjonescz mentioned this pull request Mar 27, 2024
Open
8 tasks
@jjonescz jjonescz mentioned this pull request May 16, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jaredpar jaredpar jaredpar approved these changes

@baronfel baronfel baronfel approved these changes

Assignees

No one assigned

Labels

Area-Infrastructure untriaged Request triage from a team member

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jjonescz @jaredpar @baronfel