Include version in deps.json #38087
Merged
Include version in deps.json #38087
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
This is only necessary for tests that pretend particular assemblies have been created without actually creating them
dsplaisted
reviewed
Jan 30, 2024
|
This isn't worth a test. I added two screenshots instead. |
nagilson
approved these changes
Jun 10, 2024
Good point. I can retarget to 8.0.4xx. |
…include-version-in-dps
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #12301
Assembly version is easy. File version is best effort, since I didn't see a better way to find the 'real' path to the output assembly than using the paths passed in when calling the task. I don't know if that's guaranteed to be complete, but it at least had what I needed in the simple case I was testing, and if it's missing, it should just not include it rather than failing.
Before:
After:
The app (12301.csproj in this case) has a ProjectReference to library. This adds the assembly version and file version to that reference in the deps.json.