Skip to content

Use .NET 9.0 versions for task dependencies #37013

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 30, 2023
Merged

Use .NET 9.0 versions for task dependencies #37013

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 0 additions & 5 deletions eng/SourceBuildPrebuiltBaseline.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,10 +32,5 @@
<UsagePattern IdentityGlob="System.Diagnostics.EventLog/*7.0.0*" />
<UsagePattern IdentityGlob="System.Reflection.MetadataLoadContext/*7.0.0*" />
<UsagePattern IdentityGlob="System.Security.Cryptography.ProtectedData/*7.0.0*" />

<!-- msbuild is still on 8.0 versions of these so we have to pin in SDK main for now or tasks will fail -->
Copy link
Member

@dsplaisted dsplaisted Nov 21, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this comment no longer apply? Did MSBuild switch to version 9.0 of these assemblies?

Copy link
Member Author

@ellahathaway ellahathaway Nov 28, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm a bit confused by that comment.

I don't understand how these assemblies are related to msbuild since System.Text.Json, the ref that was related to these other dependencies per https://github.com/dotnet/sdk/pull/35048/files#r1330753409, is a 7.0 version in msbuild. Second, these prebuilts were added as a workaround to an issue with the sdk tasks as part of #35048. https://github.com/dotnet/sdk/pull/35048/files#r1330753409 suggests that the issue was related to the fact that System.Text.Json was on 8.0, but msbuild is on 7.0?

This PR is getting a clean build and my local copy of the VMR with these changes is also building successfully. Based on this, I'm assuming that this comment no longer applies, but as I pointed out above, I'm a bit confused as to how the comment was relevant in the first place.

@marcpopMSFT - What are your thoughts?

Copy link
Member

@dsplaisted dsplaisted Nov 29, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If the full framework CI leg is passing then it's probably OK, for now at least. When running under Full Framework MSBuild, there can be assembly loading failures if there isn't a binding redirect for the assembly and the assembly versions don't match exactly. (We just encountered this when building 8.0.1, where we were trying to use version 8.0.1 of System.Text.Json, but Microsoft.Extensions.DependencyModel depended on version 8.0.0. The resolution was to not update to the new version of System.Text.Json for the full Framework task builds.)

<UsagePattern IdentityGlob="Microsoft.NET.HostModel/*8.0.0*" />
<UsagePattern IdentityGlob="Microsoft.Extensions.DependencyModel/*8.0.0*" />
<UsagePattern IdentityGlob="Microsoft.Bcl.AsyncInterfaces/*8.0.0*" />
</IgnorePatterns>
</UsageData>
8 changes: 4 additions & 4 deletions src/Tasks/Microsoft.NET.Build.Tasks/Microsoft.NET.Build.Tasks.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,10 +52,10 @@
<PackageReference Include="Microsoft.Build" ExcludeAssets="Runtime" />
<PackageReference Include="Microsoft.Build.Framework" ExcludeAssets="Runtime" />
<PackageReference Include="Microsoft.Build.Utilities.Core" ExcludeAssets="Runtime" />
<PackageReference Include="Microsoft.Extensions.DependencyModel" VersionOverride="8.0.0-rc.1.23419.4"/>
<PackageReference Include="Microsoft.NET.HostModel" VersionOverride="8.0.0-rc.1.23419.4"/>
<PackageReference Include="System.Text.Json" VersionOverride="8.0.0-rc.1.23419.4"/>
<PackageReference Include="Microsoft.Bcl.AsyncInterfaces" VersionOverride="8.0.0-rc.1.23419.4"/>
<PackageReference Include="Microsoft.Extensions.DependencyModel" />
<PackageReference Include="Microsoft.NET.HostModel" />
<PackageReference Include="System.Text.Json" />
<PackageReference Include="Microsoft.Bcl.AsyncInterfaces" />
<PackageReference Include="NuGet.ProjectModel" />
<PackageReference Include="NuGet.Build.Tasks.Pack" ExcludeAssets="All" />
<PackageReference Include="Microsoft.Deployment.DotNet.Releases" />
Expand Down