Skip to content

Conversation

@Forgind
Copy link
Contributor

@Forgind Forgind commented Sep 22, 2023

No description provided.

@ghost ghost added Area-Infrastructure untriaged Request triage from a team member labels Sep 22, 2023
@nagilson
Copy link
Member

I think you need to change MirrorBranch: release/8.0.1xx to 2xx in eng/build.yml

@Forgind
Copy link
Contributor Author

Forgind commented Sep 27, 2023

If I'm understanding the example set by #29942 properly, I think that change should really go into the final branding PR for 8.0.1xx? It'll flow to 8.0.2xx later, but it should be there first. Am I wrong about that?

@nagilson
Copy link
Member

If I'm understanding the example set by #29942 properly, I think that change should really go into the final branding PR for 8.0.1xx? It'll flow to 8.0.2xx later, but it should be there first. Am I wrong about that?

Hrm, good point... though that is the final branding for 7.0.2xx, its changing the mirror to 7.0.3xx. Based on that, I think it would be appropriate to say it was 7.0.2xx from the beginning of the branch, which is what this change would be?

Anyway, I'm not confident, especially if it wasn't in the list of steps to do, and I don't remember having to do that manually. @marcpopMSFT Is this supposed to be changed?

@marcpopMSFT
Copy link
Member

That controls which branch we localize. It can be done in 8.0.1xx later and flowed up. I've often done it at the same time as branching just so I don't have to remember later but either way is ok.

@Forgind Forgind merged commit d783ea6 into dotnet:release/8.0.2xx Oct 2, 2023
@Forgind Forgind deleted the 8.0.2xx-branding branch October 2, 2023 23:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Area-Infrastructure untriaged Request triage from a team member

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants