[release/8.0.1xx] Adjust trim/aot warning messages (#35186) #35595
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For completeness, these messages should mention all of the properties that can be set to produce the warning, even those that aren't the recommended way to enable trim/aot compatibility.For completeness, these messages should mention all of the properties that can be set to produce the warning, even those that aren't the recommended way to enable trim/aot compatibility.
ghost
added
vitek-karas
approved these changes
Sep 21, 2023
Member
Member
Author
|
Yup, it's ready to go. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #35186.
For completeness, these messages should mention all of the properties that can be set to produce the warning, even those that aren't the recommended way to enable trim/aot compatibility.For completeness, these messages should mention all of the properties that can be set to produce the warning, even those that aren't the recommended way to enable trim/aot compatibility.
Customer Impact
The previous warning message was confusing - it pointed to IsTrimmable when the warning was really caused by EnableTrimAnalyzer. Customers who set EnableTrimAnalyzer for an unsupported TFM will hit this warning.
The dotnet test team hit this, and customers are likely to hit it too.
Testing
Passed existing unit tests without any behavior changes. Only change is to the wording of the message.
Risk
Low. This is just a change to the wording of the warning message. However, note that the translated messages will need updating.