Skip to content

Conversation

@trungnt2910
Copy link
Contributor

This PR contains the changes to the PortableRuntimeIdentifierGraph.json as suggested in dotnet/runtime#86391 (comment), as well as some small changes to the CLI tools to allow a Haiku-aware SDK.

@ghost ghost added Area-Infrastructure untriaged Request triage from a team member labels Sep 8, 2023
Copy link
Member

@dsplaisted dsplaisted left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks fine, but per @ViktorHofer's comment we may want to move the portable graph to the dotnet/runtime repo instead.

@marcpopMSFT
Copy link
Member

@trungnt2910 did you want us to merge this or wait for a decision on where hte portable rid graph should live first? Also, this is in main which is a 9.0 branch and would need to be backported if desired in 8.0.100

CC @elinor-fung @ViktorHofer

@trungnt2910
Copy link
Contributor Author

did you want us to merge this or wait for a decision on where hte portable rid graph should live first?

If this could be merged right now, then the Haiku changes should move around with the portable RID graph, so I would prefer that.

Also, this is in main which is a 9.0 branch

I am aware of that; that's why the base branch is named haiku-dotnet9.

Seems like .NET 8 is already about to be released in a couple of months, so there's not much chance all the other changes required to get the dotnet/runtime repo working on Haiku to land on .NET 8. I therefore don't think there's much need to backport, unless the 9.0 branch won't be used by dotnet/runtime for quite a while.

@baronfel
Copy link
Member

That's reasonable to me - if the changes required to support Haiku were only SDK-level then you'd have plenty of opportunity during the 8 cycle to onboard. I don't think that we do OS support changes at a runtime-level mid-cycle though - @richlander do you have any thoughts there?

@jkotas
Copy link
Member

jkotas commented Sep 13, 2023

I don't think that we do OS support changes at a runtime-level mid-cycle though

Correct. Haiku support is not something that can be added in .NET 8 runtime servicing.

@jkotas jkotas merged commit 1aa8489 into dotnet:main Sep 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Area-Infrastructure untriaged Request triage from a team member

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants