Fix duplicate resolved files to publish #3320
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nguerrera
commented
Jun 11, 2019
| int cmp = string.CompareOrdinal(item1.PackageId, item2.PackageId); | ||
| if (cmp != 0) | ||
| { | ||
| return cmp < 0 ? item1 : item2; |
Contributor
Author
There was a problem hiding this comment.
There should probably be logging here, but I want to make a pass over all the logging in this task: see #3319
peterhuene
reviewed
Jun 11, 2019
src/Tasks/Microsoft.NET.Build.Tasks/targets/Microsoft.NET.Publish.targets
Outdated
Show resolved
Hide resolved
dsplaisted
approved these changes
Jun 11, 2019
src/Tests/Microsoft.NET.Publish.Tests/GivenThatWeWantToPublishAHelloWorldProject.cs
Outdated
Show resolved
Hide resolved
peterhuene
approved these changes
Jun 12, 2019
dsplaisted
pushed a commit
to dsplaisted/sdk
that referenced
this pull request
Feb 19, 2020
…0191025.3 (dotnet#3320) - Microsoft.AspNetCore.DeveloperCertificates.XPlat - 5.0.0-alpha1.19525.3
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #3257
There were two issues.