Swap the 1205 and 1206 error codes #33189
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…piler framework error at 1205. This stays consistent with those branches.
ghost
added
Member
Author
|
@elinor-fung was there already documentation created around NonPortableRuntimeIdentifierDetected? Mind swapping the error numbers? We had CannotDirectlyReferenceMicrosoftNetCompilersToolsetFramework go into 7.0.3xx as 1205 late last week as that was the highest number at the time and we want to be consistent between releases so the documentation is consistent. |
Forgind
approved these changes
Jun 12, 2023
elinor-fung
approved these changes
Jun 12, 2023
Member
elinor-fung
left a comment
elinor-fung
left a comment
There was a problem hiding this comment.
No doc referencing the error number. The doc link just points the breaking change notice right now. Looks good to me.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
3xx and 4xx already had the com…piler framework error at 1205. This stays consistent with those branches.