ProcessFrameworkReferences if ILLink pack is required #33062
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
- Don't publish single-file test for unsupported net472 TFM - Expect single-file to fail adding ILLink pack reference for unupported TFMs - Adjust TFM to check single-file error behavior when publishing library
|
This change is needed for netstandard2.0 and netstandard2.1 to behave consistently when An earlier version of this change was designed to let ProcessFrameworkReferences run when any tool packs were required, but I've limited the scope of the change to the ILLink pack to avoid unnecessary breaking changes. |
sbomer
changed the title
|
These changes have been integrated into #34077. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We shouldn't skip ProcessFrameworkReferences if trimming is enabled, for example. Previously, NETSDK1195 was reported for
netstandard2.1but notnetstandard2.0, because the latter didn't useFrameworkReference. This fixes the inconsistency.