Better test logging #3282
Merged
Better test logging #3282
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dsplaisted
force-pushed
the
better-test-logging
branch
from
ec25e09 to
66882d3
Compare
wli3
approved these changes
May 30, 2019
This will include both STDOUT and STDERR in the log, as well as launched process path and args
dsplaisted
force-pushed
the
better-test-logging
branch
from
66882d3 to
81b6076
Compare
dsplaisted
pushed a commit
to dsplaisted/sdk
that referenced
this pull request
Feb 19, 2020
Error ported from cli, sent pr to cli release branch to fix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes all direct uses of the CLI Utils
Commandclass, and instead routes them through the SDK'sTestCommand. This will log the start info, STDOUT, and STDERR.This will, for example, make it a lot easier to see what the problem is from the test logs when a test fails because the right shared framework isn't installed. The error information in that case goes to STDERR, which a lot of the tests which used
Command.Createweren't capturing.FYI @dotnet/dotnet-cli, we should continue to follow the new pattern of using
DotnetCommandandRunExeCommandinstead ofCommand.Createin future tests.