Skip to content

Allow opting-in to NativeAOT publishing using runtime packs #32100

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 28, 2023
Merged

Allow opting-in to NativeAOT publishing using runtime packs #32100

merged 1 commit into from
Apr 28, 2023

Conversation

@akoeplinger
Copy link
Member

@akoeplinger akoeplinger commented Apr 27, 2023 •
edited
Loading

Contributes to dotnet/runtime#81024

Installer changes are in dotnet/installer#16261

@ghost ghost added Area-Infrastructure untriaged Request triage from a team member labels Apr 27, 2023
@akoeplinger akoeplinger mentioned this pull request Apr 27, 2023
Merged
@akoeplinger akoeplinger requested a review from dsplaisted April 27, 2023 16:13
@dsplaisted
Copy link
Member

I don't really follow what's going on here. Is the AotUseKnownRuntimePackForTarget property something you'd expect developers to set to opt in to this new mode?

@akoeplinger
Copy link
Member Author

akoeplinger commented Apr 28, 2023 •
edited
Loading

@dsplaisted no, this would almost certainly only be set by the workloads (e.g. iOS/Android) that need the runtime packs. There is a chance that we will switch completely to the new mode even for desktop at which point the property would go away so I'm not particularly concerned with the naming.

Note that the "user-facing" property name is PublishAotUsingRuntimePack

dsplaisted
dsplaisted approved these changes Apr 28, 2023
View reviewed changes
Copy link
Member

@dsplaisted dsplaisted left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good so far. Sounds like changes will be needed to workloads or other logic to opt in to this. Also I'm not sure if the ILCompiler will need to be updated to know to use the runtime pack.

@akoeplinger akoeplinger merged commit e6f8a39 into dotnet:main Apr 28, 2023
@akoeplinger akoeplinger deleted the nativeaot-runtimepack branch April 28, 2023 20:10
@kotlarmilos kotlarmilos mentioned this pull request May 10, 2023
Closed
4 tasks
This was referenced Jun 1, 2023
Merged
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dsplaisted dsplaisted dsplaisted approved these changes

Assignees

No one assigned

Labels

Area-Infrastructure untriaged Request triage from a team member

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@akoeplinger @dsplaisted