Follow-up to #31559 #32047
Merged
Follow-up to #31559 #32047
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
MackinnonBuck
added
the
Area-AspNetCore
|
Thanks for your PR, @MackinnonBuck. |
MackinnonBuck
commented
Apr 25, 2023
MackinnonBuck
force-pushed
the
mbuck/31559-follow-up
branch
from
0d9a468 to
a3790af
Compare
MackinnonBuck
commented
Apr 26, 2023
| public int DeleteLength { get; set; } | ||
| } | ||
|
|
||
| private class SourceFile |
There was a problem hiding this comment.
I added this class to provide a helper for extracting line/column numbers from @import uses. We could definitely remove this if we're okay with not having line numbers in error messages. If we do that, we'll probably want to deduplicate error messages that relate to the same file.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses some follow-up items from #31559:
BrotliCompresstask if there are no files to compressAssignRazorComponentTargetPathsandAssignRazorGenerateTargetPathsfrom the StaticWebAssets SDK_StaticWebAssetsSdkRazorToolAssemblyfrom the StaticWebAssets SDKFixes dotnet/aspnetcore#47374
Fixes #32004