Split static web assets SDK from the Razor SDK #31079
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
|
Thanks for your PR, @MackinnonBuck. |
MackinnonBuck
commented
Mar 9, 2023
src/StaticWebAssetsSdk/Targets/Microsoft.NET.Sdk.StaticWebAssets.StaticWebAssets.targets
Outdated
Show resolved
Hide resolved
javiercn
approved these changes
Mar 13, 2023
javiercn
reviewed
Mar 13, 2023
| </PropertyGroup> | ||
|
|
||
| <Import Sdk="Microsoft.NET.Sdk" Project="Sdk.props" Condition="'$(_RazorSdkImportsMicrosoftNetSdk)' == 'true'" /> | ||
| <Import Sdk="Microsoft.NET.Sdk.StaticWebAssets" Project="Sdk.props" Condition="'$(_RazorSdkImportsMicrosoftNetSdkStaticWebAssets)' == 'true'" /> |
There was a problem hiding this comment.
@MackinnonBuck this is what needs to go into the Razor repo, fyi
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moves static web assets functionality out of the
RazorSDK into a newStaticWebAssetsSDK. This is part of the ongoing work to unify the Blazor WebAssembly SDK and the .NET WASM SDK (see dotnet/aspnetcore#46673).Fixes dotnet/aspnetcore#46997