-
Notifications
You must be signed in to change notification settings - Fork 1.2k
[Breaking] RuntimeIdentifier No Longer Implies SelfContained Apps by Default
#30038
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
67 commits
Select commit
Hold shift + click to select a range
8bce0b6
Make the breaking change of RID -> No Longer -> SC
nagilson ee5d568
Update XLF and remove breaking change error.
nagilson 38491c6
Improve the error message quality.
nagilson 61c2c32
Fix a test which did not properly check if app was SelfContained or not
nagilson 298649f
Update global property flow test to not expect rid to infer sc
nagilson 08ae557
Update blazor wasm tests to add SC with the new RID change
nagilson 3fd0e6d
Fix test with missing framework for RID breaking change
nagilson 2228361
Update Framework References tests to add SelfContained per breaking c…
nagilson 2202db1
Update WPF tests that expected RID to give SC
nagilson 2eb3e94
Update framework reference invalid rid and trimmable tests to no long…
nagilson 3e4f40d
Repair some publish profile tests to add SelfContained and update ano…
nagilson a8ef8c3
Update dotnet build tests to add SelfContained explicitly when needed…
nagilson 0042e6e
Update publish profile tests to add SC explicitly per .net 8 breaking…
nagilson 07848f6
Fix EXE global property flow tests to add SelfContained now when a RI…
nagilson 552b1b3
Blazor: Add SelfContained in SDK tasks project instead of the test pr…
nagilson 836ca0d
Revert "Blazor: Add SelfContained in SDK tasks project instead of the…
nagilson c0ce586
Update warning and remove old warning
nagilson 0e27149
Update newly added breaking change test to also assert SelfContained …
nagilson d4ed80c
Don't add `SelfContained` twice in the IL Link test, as this was a mi…
nagilson 3026631
Don't add `SelfContained` twice in the test, as this was a mistake
nagilson fb31004
Don't add `SelfContained` twice in the test, as this was a mistake
nagilson ada4f72
Improve test code quality by adding SelfContained in less places wher…
nagilson 3c6c89f
Add SelfContained where needed still in IL Link
nagilson 561553c
Fix remaining IL Link Tests with the new change to not add SelfContai…
nagilson 19323d9
merge with main
nagilson 9d71845
Imply SC for some publish properties as we decided to in the partner …
nagilson 8e05d08
Merge by updating string resx
nagilson 9423934
update global property flow test on merge to have the breaking change…
nagilson 1dc3859
Remove the binlog added to a test
nagilson 03a5105
update xlf and add test for publish property inference behavior
nagilson 12d72f6
Merge branch 'nagilson-rid-no-more-sc-2.0' of https://github.com/nagi…
nagilson ef50ea6
fix bad msbuild syntax
nagilson 7d7f707
fix path too long in test
nagilson 1093e5c
make the tests pass by recollecting that sc still infers rid
nagilson 704490e
fix global property flow tests to acc for new behaviour again
nagilson d20b510
Make the framework reference flow in a test by adding self contained …
nagilson e16385b
remove selfcontained added to test lib because it should get inferred
nagilson 4a4f5b4
merge string resx with artifact path
nagilson 28d4899
Merge branch 'nagilson-rid-no-more-sc-2.0' of https://github.com/nagi…
nagilson 3ea20a3
add empty targetframeworkversion check
nagilson 6bc5a45
update xlf
nagilson 698325f
Revert "remove selfcontained added to test lib because it should get …
nagilson 5d166a5
remove binlogs from tests
nagilson 915089d
use the msbuild version comparison function instead of lt and rt in r…
nagilson 000c4a6
fix container test which had different bl syntax
nagilson 5d15152
add the empty tfm check back as the msbuild function will fail if giv…
nagilson 72b31a4
Update container tests to push to correct net8 base images
baronfel 0e735e5
Improve clarity of warning message for breaking change
nagilson 26550ed
undo blazor wasm self contained test additions because they prepared …
nagilson 586ddd5
Revert "undo blazor wasm self contained test additions because they p…
nagilson c0a6f47
respond to most pr feedback
nagilson f3e8af4
WIP: Modify validate exe reference test to account for tfm
nagilson f2c674a
wip fix exe reference framework error but tfm isnt available in the …
nagilson 5f33273
Fix referenced exe error to be tfm gateD
nagilson de300bf
Add selfcontained to blazor wasm library project because it still see…
nagilson 30e5d61
Add SelfContained to the TestProject Library and clean up the tests
nagilson fafde81
Add SelfContained back into the blazor tests because they havent full…
nagilson 66806ca
fix remaining tests
nagilson 485149e
update container tag to 8 becuase older tfms dont appear to work so I…
nagilson 5909dd1
remove the binlog i forgot in the test
nagilson 912ed9f
Change Test for ReferenceExe to not Specify SelfContained if RuntimeI…
nagilson 51920b9
Account for targetframework aliases while parsing the target framewor…
nagilson aa38fe0
Refer to the new variable we created instead of the old one that shou…
nagilson 3faa0f2
Use an integer to compare versions instead of comparing with a create…
nagilson 0415c78
remove unneeeded boolean as we took a different approach to consider …
nagilson dcd802b
Merge remote-tracking branch 'upstream/main' into nagilson-rid-no-mor…
nagilson e92dee7
fix merge conflict that vscode did not save for some reason
nagilson File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.