A Basic Solution Structure to Enable Infrastructure Development #3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| <ProjectGuid>{DF7D2697-B3B4-45C2-8297-27245F528A99}</ProjectGuid> | ||
| <OutputType>Library</OutputType> | ||
| <AppDesignerFolder>Properties</AppDesignerFolder> | ||
| <RootNamespace>Microsoft.PackageDependencyResolution.Tasks</RootNamespace> |
There was a problem hiding this comment.
How many "tasks" libraries do we expect to have in this repo? This name seems very specific, and not many tasks will be able to live in this assembly.
For example, my next task is to add the tasks for "Generate .deps.json" and "Generate .runtimeconfig.json" files. I don't think they would belong in an assembly named Microsoft.PackageDependencyResolution.Tasks.
There was a problem hiding this comment.
OK, we could explore a rename
nguerrera
pushed a commit
that referenced
this pull request
Oct 10, 2016
As we discussed offline, checking this in to unblock Jenkins work
mmitche
pushed a commit
to mmitche/sdk
that referenced
this pull request
Jun 5, 2020
Importing the publish profiles from the package.
JanKrivanek
added a commit
to JanKrivanek/sdk
that referenced
this pull request
Oct 26, 2022
JanKrivanek
added a commit
to JanKrivanek/sdk
that referenced
this pull request
Oct 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This basic solution includes an empty placeholder project for the PackageDependencyResolution task. (I left out the source of the task because that is a longer review.) This PR is the minimal layout we need to start working on infrastructure tasks (Jenkins, Microbuild etc.). More detailed build.cmd, Settings.targets etc can be fleshed out later.
/cc @333fred @srivatsn @dotnet/project-system