Skip to content

[main] Update dependencies from dotnet/templating #29969

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 12 commits into from
Jan 18, 2023
Merged

[main] Update dependencies from dotnet/templating #29969

merged 12 commits into from
Jan 18, 2023

Conversation

@dotnet-maestro
Copy link
Contributor

@dotnet-maestro dotnet-maestro bot commented Jan 17, 2023 •
edited
Loading

This pull request updates the following dependencies

From https://github.com/dotnet/templating

  • Subscription: bdbeb850-6d82-4277-c391-08d8e9750d9d
  • Build: 20230118.2
  • Date Produced: January 18, 2023 12:00:50 PM UTC
  • Commit: 4827cbc295e50af2f7162172e81514ad3b671bf0
  • Branch: refs/heads/main

@dotnet-maestro
Update dependencies from https://github.com/dotnet/templating build 2…
00be70f 
…0230117.3

Microsoft.TemplateEngine.Abstractions
 From Version 8.0.100-alpha.1.23067.1 -> To Version 8.0.100-alpha.1.23067.3
@ghost ghost added the Area-CodeFlow label Jan 17, 2023
@kasperk81 kasperk81 mentioned this pull request Jan 17, 2023
Merged
@ViktorHofer
Copy link
Member

ViktorHofer commented Jan 17, 2023

@dotnet/templating-engine-maintainers can you please take a look at the failures?

@dotnet-maestro
Update dependencies from https://github.com/dotnet/templating build 2…
52ab2d2 
…0230117.4

Microsoft.TemplateEngine.Abstractions
 From Version 8.0.100-alpha.1.23067.1 -> To Version 8.0.100-alpha.1.23067.4
@YuliiaKovalova
Copy link
Member

YuliiaKovalova commented Jan 17, 2023

I am taking a look

@dotnet-maestro
Update dependencies from https://github.com/dotnet/templating build 2…
9a81d8d 
…0230117.5

Microsoft.TemplateEngine.Abstractions
 From Version 8.0.100-alpha.1.23067.1 -> To Version 8.0.100-alpha.1.23067.5
@ViktorHofer
Copy link
Member

ViktorHofer commented Jan 17, 2023 •
edited
Loading

@dotnet/templating-engine-maintainers in addition to the test failures, there are build errors now as well with the latest dependency update:

/home/vsts/work/1/s/src/Cli/Microsoft.TemplateEngine.Cli/CliTemplateEngineHost.cs(87,34): error CS0539: 'CliTemplateEngineHost.LogDiagnosticMessage(string, string, params string[])' in explicit interface declaration is not found among members of the interface that can be implemented [/home/vsts/work/1/s/src/Cli/Microsoft.TemplateEngine.Cli/Microsoft.TemplateEngine.Cli.csproj::TargetFramework=net8.0]
##[error]src/Cli/Microsoft.TemplateEngine.Cli/CliTemplateEngineHost.cs(87,34): error CS0539: (NETCORE_ENGINEERING_TELEMETRY=Build) 'CliTemplateEngineHost.LogDiagnosticMessage(string, string, params string[])' in explicit interface declaration is not found among members of the interface that can be implemented
/home/vsts/work/1/s/src/Cli/Microsoft.TemplateEngine.Cli/CliTemplateEngineHost.cs(94,34): error CS0539: 'CliTemplateEngineHost.LogTiming(string, TimeSpan, int)' in explicit interface declaration is not found among members of the interface that can be implemented [/home/vsts/work/1/s/src/Cli/Microsoft.TemplateEngine.Cli/Microsoft.TemplateEngine.Cli.csproj::TargetFramework=net8.0]
##[error]src/Cli/Microsoft.TemplateEngine.Cli/CliTemplateEngineHost.cs(94,34): error CS0539: (NETCORE_ENGINEERING_TELEMETRY=Build) 'CliTemplateEngineHost.LogTiming(string, TimeSpan, int)' in explicit interface declaration is not found among members of the interface that can be implemented
/home/vsts/work/1/s/src/Cli/Microsoft.TemplateEngine.Cli/CliTemplateEngineHost.cs(101,34): error CS0539: 'CliTemplateEngineHost.LogMessage(string)' in explicit interface declaration is not found among members of the interface that can be implemented [/home/vsts/work/1/s/src/Cli/Microsoft.TemplateEngine.Cli/Microsoft.TemplateEngine.Cli.csproj::TargetFramework=net8.0]
##[error]src/Cli/Microsoft.TemplateEngine.Cli/CliTemplateEngineHost.cs(101,34): error CS0539: (NETCORE_ENGINEERING_TELEMETRY=Build) 'CliTemplateEngineHost.LogMessage(string)' in explicit interface declaration is not found among members of the interface that can be implemented

@ViktorHofer ViktorHofer requested a review from a team as a code owner January 17, 2023 17:15
ViktorHofer and others added 3 commits January 17, 2023 18:39
@ViktorHofer
React to obsolete members being removed
fba25f5
@dotnet-maestro
Update dependencies from https://github.com/dotnet/templating build 2…
3156f78 
…0230117.6

Microsoft.TemplateEngine.Abstractions
 From Version 8.0.100-alpha.1.23067.1 -> To Version 8.0.100-alpha.1.23067.6
@dotnet-maestro
Update dependencies from https://github.com/dotnet/templating build 2…
289b1b6 
…0230117.7

Microsoft.TemplateEngine.Abstractions
 From Version 8.0.100-alpha.1.23067.1 -> To Version 8.0.100-alpha.1.23067.7
@ViktorHofer ViktorHofer mentioned this pull request Jan 17, 2023
Merged
@vlada-shubina vlada-shubina added the Area-dotnet new the item is related to dotnet new command label Jan 18, 2023
@dotnet-maestro
Update dependencies from https://github.com/dotnet/templating build 2…
c17d691 
…0230118.1

Microsoft.TemplateEngine.Abstractions
 From Version 8.0.100-alpha.1.23067.1 -> To Version 8.0.100-alpha.1.23068.1
@dotnet-maestro
Update dependencies from https://github.com/dotnet/templating build 2…
1b476bf 
…0230118.2

Microsoft.TemplateEngine.Abstractions
 From Version 8.0.100-alpha.1.23067.1 -> To Version 8.0.100-alpha.1.23068.2
vlada-shubina
vlada-shubina previously requested changes Jan 18, 2023
View reviewed changes
Copy link
Member

@vlada-shubina vlada-shubina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OnPotentiallyDestructiveChangesDetected is custom in dotnet CLI and should stay.

@dotnet dotnet deleted a comment from vlada-shubina Jan 18, 2023
@YuliiaKovalova YuliiaKovalova dismissed vlada-shubina’s stale review January 18, 2023 13:04

Maestro auto-merge - No Requested Changes

@ViktorHofer ViktorHofer merged commit 25cc303 into main Jan 18, 2023
@ViktorHofer ViktorHofer deleted the darc-main-7eecd4e2-cf48-4210-9031-b0bdc68d480d branch January 18, 2023 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vlada-shubina vlada-shubina vlada-shubina approved these changes

Assignees

No one assigned

Labels

Area-CodeFlow Area-dotnet new the item is related to dotnet new command

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@ViktorHofer @YuliiaKovalova @vlada-shubina