Skip to content

Conversation

@vzarytovskii
Copy link
Member

As we figured out here, SDK is not getting runtimeconfig.json files from F# itself, but from the https://github.com/dotnet/sdk/blob/release/7.0.2xx/src/Layout/tool_fsharp/tool_fsc.csproj

<!-- Deploy deps and runtime config for fsc.exe and fsi.exe. Both apps have exactly the same dependencies so this is Ok -->
<Copy SourceFiles="$(FSharpDirectory)/tool_fsc.runtimeconfig.json;
$(FSharpDirectory)/tool_fsc.deps.json;"
DestinationFiles="$(FSharpDirectory)/fsc.runtimeconfig.json;
$(FSharpDirectory)/fsc.deps.json;"/>
<Copy SourceFiles="$(FSharpDirectory)/tool_fsc.runtimeconfig.json;
$(FSharpDirectory)/tool_fsc.deps.json;"
DestinationFiles="$(FSharpDirectory)/fsi.runtimeconfig.json;
$(FSharpDirectory)/fsi.deps.json;"/>

Hopefully, it's the proper place to make the change, if not, please advise what would be thecorrect one.

Update: will also need to verify that these changes do affect runtimeconfig, when build is complete.

@baronfel
Copy link
Member

I cloned this down, built it, and verified that the server GC was set in the runtimeconfig.json:

../FSharp on vzarytovskii-patch-1
11:34:56 ❯ cat *.runtime*
{
  "runtimeOptions": {
    "tfm": "net8.0",
    "framework": {
      "name": "Microsoft.NETCore.App",
      "version": "8.0.0-alpha.1.22605.1"
    },
    "configProperties": {
      "System.GC.Server": true
    }
  }
}
{
  "runtimeOptions": {
    "tfm": "net8.0",
    "framework": {
      "name": "Microsoft.NETCore.App",
      "version": "8.0.0-alpha.1.22605.1"
    },
    "configProperties": {
      "System.GC.Server": true
    }
  }
}

This was on the main-targeted form of this PR, but the result should be the same.

@baronfel baronfel merged commit 4b1f983 into release/7.0.2xx Dec 14, 2022
@baronfel baronfel deleted the vzarytovskii-patch-2 branch December 14, 2022 22:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants