Avoid potential NRE #29128
Merged
Avoid potential NRE #29128
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
javiercn
approved these changes
Nov 18, 2022
Contributor
|
/backport to main |
marek-safar
pushed a commit
that referenced
this pull request
Nov 21, 2022
marek-safar
added a commit
that referenced
this pull request
Nov 21, 2022
Co-authored-by: Tomáš Matoušek <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add defensive null check.
Some tests in main are failing with NRE. These tests seem to pass in 7.0.2xx but it's not currently clear when RuntimeIdentifier and DefaultAppHostRuntimeIdentifier are non-null. Will follow up with adding null annotations in main.
Fixes #29085