Skip to content

[main] Update dependencies from dotnet/command-line-api #29012

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Nov 15, 2022
Merged

[main] Update dependencies from dotnet/command-line-api #29012

merged 9 commits into from
Nov 15, 2022

Conversation

@dotnet-maestro
Copy link
Contributor

@dotnet-maestro dotnet-maestro bot commented Nov 10, 2022 •
edited
Loading

This pull request updates the following dependencies

From https://github.com/dotnet/command-line-api

  • Subscription: a08a5052-c9e7-44a2-9fba-08d94728d7f2
  • Build: 20221114.1
  • Date Produced: November 14, 2022 7:25:30 PM UTC
  • Commit: 8374d5fca634a93458c84414b1604c12f765d1ab
  • Branch: refs/heads/main

@dotnet-maestro
Update dependencies from https://github.com/dotnet/command-line-api b…
5bb99b9 
…uild 20221110.1

Microsoft.SourceBuild.Intermediate.command-line-api , System.CommandLine
 From Version 0.1.352601 -> To Version 0.1.356001
@ghost ghost added the Area-CodeFlow label Nov 10, 2022
@dotnet-maestro
Update dependencies from https://github.com/dotnet/command-line-api b…
7f59c81 
…uild 20221110.2

Microsoft.SourceBuild.Intermediate.command-line-api , System.CommandLine
 From Version 0.1.352601 -> To Version 0.1.356002
@dotnet-maestro
Update dependencies from https://github.com/dotnet/command-line-api b…
9676433 
…uild 20221110.3

Microsoft.SourceBuild.Intermediate.command-line-api , System.CommandLine
 From Version 0.1.352601 -> To Version 0.1.356003
@dsplaisted
Copy link
Member

dsplaisted commented Nov 11, 2022

/Users/runner/work/1/s/src/BuiltInTools/dotnet-watch/Program.cs(477,49): error CS1061: 'ParseResult' does not contain a definition for 'GetValueForOption' and no accessible extension method 'GetValueForOption' accepting a first argument of type 'ParseResult' could be found (are you missing a using directive or an assembly reference?) [/Users/runner/work/1/s/src/BuiltInTools/dotnet-watch/dotnet-watch.csproj]

@jonsequitur @baronfel @dotnet/system-commandline Are there breaking API changes from System.CommandLine coming in here?

@dotnet-maestro
Update dependencies from https://github.com/dotnet/command-line-api b…
2f978b4 
…uild 20221111.1

Microsoft.SourceBuild.Intermediate.command-line-api , System.CommandLine
 From Version 0.1.352601 -> To Version 0.1.356101
@adamsitnik adamsitnik self-assigned this Nov 14, 2022
@adamsitnik
Copy link
Member

adamsitnik commented Nov 14, 2022

Are there breaking API changes from System.CommandLine coming in here?

Yes, we are currently working on moving S.CL to BCL and part of the process is introducing some breaking changes (to improve the API design). I am going to push fixes to this branch to unblock the PR.

@adamsitnik
adopt to recent System.CommandLine breaking changes:
16ba12b 
* rename "GetValueForOption" and "GetValueForArgument" to just "GetValue"
* rename "getDefaultValue" to "defaultValueFactory"
* rename "FromAmong" to "AcceptOnlyFromAmong"
* rename "ExistingOnly" to "AcceptExistingOnly"
* replace CompletionDelegate with Func<CompletionContext, IEnumerable<CompletionItem>>
* replace ParseArgument<T> with Func<ArgumentResult, T>
* replace HelpSectionDelegate with Action<HelpContext>

remove unused usings
@adamsitnik adamsitnik requested review from a team, JoeRobich and jmarolf as code owners November 14, 2022 11:00
@adamsitnik adamsitnik mentioned this pull request Nov 14, 2022
Closed
@adamsitnik
Copy link
Member

adamsitnik commented Nov 14, 2022

This PR is currently blocked by dotnet/command-line-api#1963

@adamsitnik
Copy link
Member

adamsitnik commented Nov 14, 2022

The fix in S.CL got merged (dotnet/command-line-api#1964) so now it should be just a matter of the nuget package update getting here.

dotnet-maestro bot and others added 2 commits November 14, 2022 20:04
@dotnet-maestro
Update dependencies from https://github.com/dotnet/command-line-api b…
ec5bcff 
…uild 20221114.1

Microsoft.SourceBuild.Intermediate.command-line-api , System.CommandLine
 From Version 0.1.352601 -> To Version 0.1.356401
@adamsitnik
last two fixes
1b08dd2
adamsitnik
adamsitnik approved these changes Nov 15, 2022
View reviewed changes
Copy link
Member

@adamsitnik adamsitnik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@adamsitnik
Copy link
Member

adamsitnik commented Nov 15, 2022

@dsplaisted @ViktorHofer is it OK for me to merge this PR if all the changes here were done by myself?

@dotnet-maestro dotnet-maestro bot merged commit b68de63 into main Nov 15, 2022
@dotnet-maestro dotnet-maestro bot deleted the darc-main-5ed9494d-dda3-47db-8acc-f6401f66b5ad branch November 15, 2022 13:28
@baronfel
Copy link
Member

baronfel commented Nov 15, 2022

FWIW I looked over this just now and it looks great to me 👍 Thanks for taking the time to handle the API changes, @adamsitnik

@v-wuzhai v-wuzhai restored the darc-main-5ed9494d-dda3-47db-8acc-f6401f66b5ad branch November 16, 2022 08:18
@v-wuzhai v-wuzhai deleted the darc-main-5ed9494d-dda3-47db-8acc-f6401f66b5ad branch November 17, 2022 02:05
@adamsitnik adamsitnik mentioned this pull request Nov 18, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@adamsitnik adamsitnik adamsitnik approved these changes

@jmarolf jmarolf Awaiting requested review from jmarolf

@JoeRobich JoeRobich Awaiting requested review from JoeRobich

Assignees

@adamsitnik adamsitnik

Labels

Area-CodeFlow

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@dsplaisted @adamsitnik @baronfel @ViktorHofer