Update the target framework for the desktop test projects #28932
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
nohwnd
reviewed
Nov 8, 2022
|
|
||
| <PropertyGroup> | ||
| <TargetFrameworks>net461;netcoreapp3.1</TargetFrameworks> | ||
| <TargetFrameworks>net461;$(CurrentTargetFramework)</TargetFrameworks> |
Member
There was a problem hiding this comment.
I am torn about the naming here (and all other instances). This project now forces me to double check what CurrentTargetFramework is to understand what is going on. But I guess it is better at communicating the intent than having the variable named net6 and then having to rename it every time there is an upgrade.
Member
|
Looks okay to me. This targets 6.0.4xx, I am not sure about the rules to merge to that branch, so I will defer the approval to someone else, probably Marc. |
marcpopMSFT
approved these changes
Nov 23, 2022
Member
|
merge when the branch is open next week. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.