-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Include ijwhost in DesignerRuntimeImplementationProjectOutputGroupOutput #28929
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Include ijwhost in DesignerRuntimeImplementationProjectOutputGroupOutput #28929
Conversation
dsplaisted
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would it be possible to validate the end-to-end scenario where this will fix the designer loading?
src/Tasks/Microsoft.NET.Build.Tasks/targets/Microsoft.NET.DesignerSupport.targets
Show resolved
Hide resolved
I asked @Shyam-Gupta over e-mail if he could validate. |
dsplaisted
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Note that the main branch is for the .NET 8 SDK, you should probably retarget this to release/7.0.2xx if you want this to go in the next feature release of the SDK.
b6170dd to
aeba920
Compare
|
Thanks - retargeted. I don't know much about the release/branching in sdk - is |
|
|
ijwhostis required for C++/CLI assemblies. If a project that has a designer (like WinForms) references a C++/CLI assembly, it needs to be told aboutijwhost.It looks like there is no automated testing support for C++/CLI projects right now due to #11008. I just manually ran
msbuild /t:DesignerRuntimeImplementationProjectOutputGroupon a C++/CLI project and checked that ijwhost was in the target outputs.