Skip to content

Conversation

@elinor-fung
Copy link
Member

@elinor-fung elinor-fung commented Nov 8, 2022

ijwhost is required for C++/CLI assemblies. If a project that has a designer (like WinForms) references a C++/CLI assembly, it needs to be told about ijwhost.

It looks like there is no automated testing support for C++/CLI projects right now due to #11008. I just manually ran msbuild /t:DesignerRuntimeImplementationProjectOutputGroup on a C++/CLI project and checked that ijwhost was in the target outputs.

Copy link
Member

@dsplaisted dsplaisted left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it be possible to validate the end-to-end scenario where this will fix the designer loading?

@elinor-fung
Copy link
Member Author

Would it be possible to validate the end-to-end scenario where this will fix the designer loading?

I asked @Shyam-Gupta over e-mail if he could validate.

Copy link
Member

@dsplaisted dsplaisted left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Note that the main branch is for the .NET 8 SDK, you should probably retarget this to release/7.0.2xx if you want this to go in the next feature release of the SDK.

@elinor-fung elinor-fung changed the base branch from main to release/7.0.2xx November 11, 2022 21:20
@elinor-fung
Copy link
Member Author

Thanks - retargeted. I don't know much about the release/branching in sdk - is release/7.0.2xx open or is there some sort of approval process? Does it flow back to main or would I need to port it?

@dsplaisted
Copy link
Member

release/7.0.2xx is open and changes will automatically flow into main (eventually).

@dsplaisted dsplaisted merged commit b1e1cfb into dotnet:release/7.0.2xx Nov 14, 2022
@elinor-fung elinor-fung deleted the ijwhost-designer-output branch November 15, 2022 23:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants