Introduce a class library Microsoft.DotNet.ApiSymbolExtensions #28855
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andriipatsula
requested review from
a team,
ericstj and
joperezr
as code owners
|
I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label. |
Member
Author
andriipatsula
changed the title
ViktorHofer
requested changes
Nov 2, 2022
Member
ViktorHofer
left a comment
ViktorHofer
left a comment
There was a problem hiding this comment.
DotNet.ApiCompatibility/Resources.resx → ApiSymbolExtension/ExtensionResources.resx
We don't want to share all the resource strings. Just the ones that are used by both components, i.e. for assembly symbol loading.
andriipatsula
force-pushed
the
create_apisymbolextension_shared_project
branch
from
9677d6f to
74cbe4e
Compare
andriipatsula
force-pushed
the
create_apisymbolextension_shared_project
branch
from
6dfab04 to
e473f4d
Compare
smasher164
reviewed
Nov 2, 2022
…rary. Added Microsoft.DotNet.ApiSymbolExtensions.Tests test project
andriipatsula
changed the title
andriipatsula
changed the title
Member
Author
|
@ViktorHofer , @smasher164 please take a look |
andriipatsula
changed the title
ViktorHofer
reviewed
Nov 7, 2022
src/Microsoft.DotNet.ApiSymbolExtensions/Microsoft.DotNet.ApiSymbolExtensions.csproj
Outdated
Show resolved
Hide resolved
ViktorHofer
reviewed
Nov 7, 2022
ViktorHofer
approved these changes
Nov 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Microsoft.DotNet.ApiSymbolExtensionswith pathsrc\sdkthat share common code base: classes, interfaces, resources between theApiCompatand theGenAPItools.Microsoft.DotNet.ApiSymbolExtensions.Testsand move AssemblySymbolLoaderTests.cs fromMicrosoft.DotNet.ApiCompatibility.Testssdk\src\ApiCompat\Microsoft.DotNet.ApiCompatibilityfolder to thesdk\src\Microsoft.DotNet.ApiSymbolExtensions