Skip to content

Do not eagerly discover CWD during parser construction #28836

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 18, 2023
Merged

Do not eagerly discover CWD during parser construction #28836

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions src/Cli/dotnet/CommonOptions.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,9 +94,13 @@ public static Option<string> ConfigurationOption(string description) =>
ArgumentHelpName = CommonLocalizableStrings.VersionSuffixArgumentName
}.ForwardAsSingle(o => $"-property:VersionSuffix={o}");

public static Argument<T> DefaultToCurrentDirectory<T>(this Argument<T> arg)
public static Lazy<string> NormalizedCurrentDirectory = new Lazy<string>(() => PathUtility.EnsureTrailingSlash(Directory.GetCurrentDirectory()));

public static Argument<string> DefaultToCurrentDirectory(this Argument<string> arg)
{
arg.SetDefaultValue(PathUtility.EnsureTrailingSlash(Directory.GetCurrentDirectory()));
// we set this lazily so that we don't pay the overhead of determining the
// CWD multiple times, one for each Argument that uses this.
arg.SetDefaultValueFactory(() => NormalizedCurrentDirectory.Value);
return arg;
}

Expand Down