Skip to content

Detect Corrupt Solution File in Dotnet Sln Add #28811

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jan 12, 2023
Merged

Detect Corrupt Solution File in Dotnet Sln Add #28811

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3fbf38b
Detect corrupt sln file
nagilson Oct 28, 2022
3cde268
Improve error quality
nagilson Oct 28, 2022
e087208
Update error message and respond to feedback
nagilson Nov 3, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/Cli/Microsoft.DotNet.Cli.Sln.Internal/LocalizableStrings.resx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -150,4 +150,4 @@
<data name="ClosingSectionTagNotFoundError" xml:space="preserve">
<value>Closing section tag not found</value>
</data>
</root>
</root>
3 changes: 3 additions & 0 deletions src/Cli/dotnet/CommonLocalizableStrings.resx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -712,4 +712,7 @@ The default is 'true' if a runtime identifier is specified.</value>
<data name="CustomConfigurationDisablesPublishAndPackReleaseProperties" xml:space="preserve">
<value>A custom configuration was detected in the project '{0}', so the property '{1}' will not take effect.</value>
</data>
<data name="CorruptSolutionProjectFolderStructure" xml:space="preserve">
<value>The solution file '{0}' is missing EndProject tags or has invalid child-parent project folder mappings around project GUID: '{1}'. Manually repair the solution or try to open and save it in Visual Studio."</value>
</data>
</root>
6 changes: 4 additions & 2 deletions src/Cli/dotnet/SlnFileExtensions.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -190,7 +190,7 @@ private static string MapSolutionConfigKeyToProjectConfigKey(
Dictionary<string, string> projectPlatforms,
string defaultProjectPlatform)
{
var pair = solutionConfigKey.Split(new char[] {'|'}, 2);
var pair = solutionConfigKey.Split(new char[] { '|' }, 2);
if (pair.Length != 2)
{
return null;
Expand Down Expand Up @@ -269,7 +269,9 @@ private static IDictionary<string, string> GetSolutionFolderPaths(
while (nestedProjects.ContainsKey(id))
{
id = nestedProjects[id];
var parentSlnProject = solutionFolderProjects.Where(p => p.Id == id).Single();
var parentSlnProject = solutionFolderProjects.Where(p => p.Id == id).SingleOrDefault();
if(parentSlnProject == null) // see: https://github.com/dotnet/sdk/pull/28811
throw new GracefulException(CommonLocalizableStrings.CorruptSolutionProjectFolderStructure, slnFile.FullPath, id);
path = Path.Combine(parentSlnProject.FilePath, path);
}

Expand Down
5 changes: 5 additions & 0 deletions src/Cli/dotnet/xlf/CommonLocalizableStrings.cs.xlf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,11 @@
<target state="translated">Umožňuje instalaci předběžných verzí balíčků.</target>
<note />
</trans-unit>
<trans-unit id="CorruptSolutionProjectFolderStructure">
<source>The solution file '{0}' is missing EndProject tags or has invalid child-parent project folder mappings around project GUID: '{1}'. Manually repair the solution or try to open and save it in Visual Studio."</source>
<target state="new">The solution file '{0}' is missing EndProject tags or has invalid child-parent project folder mappings around project GUID: '{1}'. Manually repair the solution or try to open and save it in Visual Studio."</target>
<note />
</trans-unit>
<trans-unit id="CouldNotFindAnyProjectInDirectory">
<source>Could not find any project in `{0}`.</source>
<target state="translated">V {0} se nenašel žádný projekt.</target>
Expand Down
5 changes: 5 additions & 0 deletions src/Cli/dotnet/xlf/CommonLocalizableStrings.de.xlf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,11 @@
<target state="translated">Ermöglicht die Installation von Paketen mit Vorabversionen.</target>
<note />
</trans-unit>
<trans-unit id="CorruptSolutionProjectFolderStructure">
<source>The solution file '{0}' is missing EndProject tags or has invalid child-parent project folder mappings around project GUID: '{1}'. Manually repair the solution or try to open and save it in Visual Studio."</source>
<target state="new">The solution file '{0}' is missing EndProject tags or has invalid child-parent project folder mappings around project GUID: '{1}'. Manually repair the solution or try to open and save it in Visual Studio."</target>
<note />
</trans-unit>
<trans-unit id="CouldNotFindAnyProjectInDirectory">
<source>Could not find any project in `{0}`.</source>
<target state="translated">In "{0}" wurde kein Projekt gefunden.</target>
Expand Down
5 changes: 5 additions & 0 deletions src/Cli/dotnet/xlf/CommonLocalizableStrings.es.xlf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,11 @@
<target state="translated">Permite que se instalen paquetes de versión preliminar.</target>
<note />
</trans-unit>
<trans-unit id="CorruptSolutionProjectFolderStructure">
<source>The solution file '{0}' is missing EndProject tags or has invalid child-parent project folder mappings around project GUID: '{1}'. Manually repair the solution or try to open and save it in Visual Studio."</source>
<target state="new">The solution file '{0}' is missing EndProject tags or has invalid child-parent project folder mappings around project GUID: '{1}'. Manually repair the solution or try to open and save it in Visual Studio."</target>
<note />
</trans-unit>
<trans-unit id="CouldNotFindAnyProjectInDirectory">
<source>Could not find any project in `{0}`.</source>
<target state="translated">No se encuentra ningún proyecto en "{0}".</target>
Expand Down
5 changes: 5 additions & 0 deletions src/Cli/dotnet/xlf/CommonLocalizableStrings.fr.xlf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,11 @@
<target state="translated">Permet d'installer les packages de préversion.</target>
<note />
</trans-unit>
<trans-unit id="CorruptSolutionProjectFolderStructure">
<source>The solution file '{0}' is missing EndProject tags or has invalid child-parent project folder mappings around project GUID: '{1}'. Manually repair the solution or try to open and save it in Visual Studio."</source>
<target state="new">The solution file '{0}' is missing EndProject tags or has invalid child-parent project folder mappings around project GUID: '{1}'. Manually repair the solution or try to open and save it in Visual Studio."</target>
<note />
</trans-unit>
<trans-unit id="CouldNotFindAnyProjectInDirectory">
<source>Could not find any project in `{0}`.</source>
<target state="translated">Projet introuvable dans '{0}'.</target>
Expand Down
5 changes: 5 additions & 0 deletions src/Cli/dotnet/xlf/CommonLocalizableStrings.it.xlf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,11 @@
<target state="translated">Consente l'installazione di pacchetti non definitivi.</target>
<note />
</trans-unit>
<trans-unit id="CorruptSolutionProjectFolderStructure">
<source>The solution file '{0}' is missing EndProject tags or has invalid child-parent project folder mappings around project GUID: '{1}'. Manually repair the solution or try to open and save it in Visual Studio."</source>
<target state="new">The solution file '{0}' is missing EndProject tags or has invalid child-parent project folder mappings around project GUID: '{1}'. Manually repair the solution or try to open and save it in Visual Studio."</target>
<note />
</trans-unit>
<trans-unit id="CouldNotFindAnyProjectInDirectory">
<source>Could not find any project in `{0}`.</source>
<target state="translated">Non è stato trovato alcun progetto in `{0}`.</target>
Expand Down
5 changes: 5 additions & 0 deletions src/Cli/dotnet/xlf/CommonLocalizableStrings.ja.xlf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,11 @@
<target state="translated">プレリリース パッケージのインストールを許可します。</target>
<note />
</trans-unit>
<trans-unit id="CorruptSolutionProjectFolderStructure">
<source>The solution file '{0}' is missing EndProject tags or has invalid child-parent project folder mappings around project GUID: '{1}'. Manually repair the solution or try to open and save it in Visual Studio."</source>
<target state="new">The solution file '{0}' is missing EndProject tags or has invalid child-parent project folder mappings around project GUID: '{1}'. Manually repair the solution or try to open and save it in Visual Studio."</target>
<note />
</trans-unit>
<trans-unit id="CouldNotFindAnyProjectInDirectory">
<source>Could not find any project in `{0}`.</source>
<target state="translated">`{0}` にプロジェクトが見つかりませんでした。</target>
Expand Down
5 changes: 5 additions & 0 deletions src/Cli/dotnet/xlf/CommonLocalizableStrings.ko.xlf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,11 @@
<target state="translated">시험판 패키지를 설치할 수 있습니다.</target>
<note />
</trans-unit>
<trans-unit id="CorruptSolutionProjectFolderStructure">
<source>The solution file '{0}' is missing EndProject tags or has invalid child-parent project folder mappings around project GUID: '{1}'. Manually repair the solution or try to open and save it in Visual Studio."</source>
<target state="new">The solution file '{0}' is missing EndProject tags or has invalid child-parent project folder mappings around project GUID: '{1}'. Manually repair the solution or try to open and save it in Visual Studio."</target>
<note />
</trans-unit>
<trans-unit id="CouldNotFindAnyProjectInDirectory">
<source>Could not find any project in `{0}`.</source>
<target state="translated">'{0}'에서 프로젝트를 찾을 수 없습니다.</target>
Expand Down
5 changes: 5 additions & 0 deletions src/Cli/dotnet/xlf/CommonLocalizableStrings.pl.xlf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,11 @@
<target state="translated">Zezwala na instalowanie pakietów wersji wstępnych.</target>
<note />
</trans-unit>
<trans-unit id="CorruptSolutionProjectFolderStructure">
<source>The solution file '{0}' is missing EndProject tags or has invalid child-parent project folder mappings around project GUID: '{1}'. Manually repair the solution or try to open and save it in Visual Studio."</source>
<target state="new">The solution file '{0}' is missing EndProject tags or has invalid child-parent project folder mappings around project GUID: '{1}'. Manually repair the solution or try to open and save it in Visual Studio."</target>
<note />
</trans-unit>
<trans-unit id="CouldNotFindAnyProjectInDirectory">
<source>Could not find any project in `{0}`.</source>
<target state="translated">Nie można odnaleźć żadnego projektu w lokalizacji „{0}”.</target>
Expand Down
5 changes: 5 additions & 0 deletions src/Cli/dotnet/xlf/CommonLocalizableStrings.pt-BR.xlf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,11 @@
<target state="translated">Permite a instalação de pacotes de pré-lançamento.</target>
<note />
</trans-unit>
<trans-unit id="CorruptSolutionProjectFolderStructure">
<source>The solution file '{0}' is missing EndProject tags or has invalid child-parent project folder mappings around project GUID: '{1}'. Manually repair the solution or try to open and save it in Visual Studio."</source>
<target state="new">The solution file '{0}' is missing EndProject tags or has invalid child-parent project folder mappings around project GUID: '{1}'. Manually repair the solution or try to open and save it in Visual Studio."</target>
<note />
</trans-unit>
<trans-unit id="CouldNotFindAnyProjectInDirectory">
<source>Could not find any project in `{0}`.</source>
<target state="translated">Não foi possível encontrar nenhum projeto em ‘{0}’.</target>
Expand Down
5 changes: 5 additions & 0 deletions src/Cli/dotnet/xlf/CommonLocalizableStrings.ru.xlf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,11 @@
<target state="translated">Разрешает установку пакетов предварительного выпуска.</target>
<note />
</trans-unit>
<trans-unit id="CorruptSolutionProjectFolderStructure">
<source>The solution file '{0}' is missing EndProject tags or has invalid child-parent project folder mappings around project GUID: '{1}'. Manually repair the solution or try to open and save it in Visual Studio."</source>
<target state="new">The solution file '{0}' is missing EndProject tags or has invalid child-parent project folder mappings around project GUID: '{1}'. Manually repair the solution or try to open and save it in Visual Studio."</target>
<note />
</trans-unit>
<trans-unit id="CouldNotFindAnyProjectInDirectory">
<source>Could not find any project in `{0}`.</source>
<target state="translated">Не удалось найти проекты в "{0}".</target>
Expand Down
5 changes: 5 additions & 0 deletions src/Cli/dotnet/xlf/CommonLocalizableStrings.tr.xlf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,11 @@
<target state="translated">Ön sürüm paketlerinin yüklenmesini sağlar.</target>
<note />
</trans-unit>
<trans-unit id="CorruptSolutionProjectFolderStructure">
<source>The solution file '{0}' is missing EndProject tags or has invalid child-parent project folder mappings around project GUID: '{1}'. Manually repair the solution or try to open and save it in Visual Studio."</source>
<target state="new">The solution file '{0}' is missing EndProject tags or has invalid child-parent project folder mappings around project GUID: '{1}'. Manually repair the solution or try to open and save it in Visual Studio."</target>
<note />
</trans-unit>
<trans-unit id="CouldNotFindAnyProjectInDirectory">
<source>Could not find any project in `{0}`.</source>
<target state="translated">`{0}` içinde proje bulunamadı.</target>
Expand Down
5 changes: 5 additions & 0 deletions src/Cli/dotnet/xlf/CommonLocalizableStrings.zh-Hans.xlf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,11 @@
<target state="translated">允许安装预发行包。</target>
<note />
</trans-unit>
<trans-unit id="CorruptSolutionProjectFolderStructure">
<source>The solution file '{0}' is missing EndProject tags or has invalid child-parent project folder mappings around project GUID: '{1}'. Manually repair the solution or try to open and save it in Visual Studio."</source>
<target state="new">The solution file '{0}' is missing EndProject tags or has invalid child-parent project folder mappings around project GUID: '{1}'. Manually repair the solution or try to open and save it in Visual Studio."</target>
<note />
</trans-unit>
<trans-unit id="CouldNotFindAnyProjectInDirectory">
<source>Could not find any project in `{0}`.</source>
<target state="translated">“{0}”中找不到任何项目。</target>
Expand Down
5 changes: 5 additions & 0 deletions src/Cli/dotnet/xlf/CommonLocalizableStrings.zh-Hant.xlf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,11 @@
<target state="translated">允許安裝發行前版本套件。</target>
<note />
</trans-unit>
<trans-unit id="CorruptSolutionProjectFolderStructure">
<source>The solution file '{0}' is missing EndProject tags or has invalid child-parent project folder mappings around project GUID: '{1}'. Manually repair the solution or try to open and save it in Visual Studio."</source>
<target state="new">The solution file '{0}' is missing EndProject tags or has invalid child-parent project folder mappings around project GUID: '{1}'. Manually repair the solution or try to open and save it in Visual Studio."</target>
<note />
</trans-unit>
<trans-unit id="CouldNotFindAnyProjectInDirectory">
<source>Could not find any project in `{0}`.</source>
<target state="translated">在 `{0}` 中找不到任何專案。</target>
Expand Down