Skip to content

Introduce PublishSelfContained #28714

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 20 commits into from
Nov 4, 2022
Merged

Introduce PublishSelfContained #28714

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
20 commits
Select commit Hold shift + click to select a range
35bdab7
Implement publish-self-contained and add tests.
nagilson Sep 16, 2022
5a3000e
Test now considers proper behavior with globals
nagilson Oct 21, 2022
0908423
Change the precedence of SC vs PSC
nagilson Oct 21, 2022
30fc065
Remove redundant tests
nagilson Oct 21, 2022
537f69e
Only do the RID inference if we're publishing.
nagilson Oct 21, 2022
bac1d6d
Add PSC RID test
nagilson Oct 21, 2022
385a936
Use unique test names in theory so helix doesnt be a baka:
nagilson Oct 21, 2022
8516ab6
Clean up code around targets
nagilson Oct 25, 2022
d923dae
Dont use PSC for RID checks.
nagilson Oct 25, 2022
7c50bac
Consider the case where SelfContained is global but not passed in CLI
nagilson Oct 25, 2022
c95ff57
All of the examples work now
nagilson Oct 25, 2022
a2f448b
Remove bl artifact
nagilson Oct 25, 2022
91fc5b0
Remove the ridiculous amount of overengineering
nagilson Oct 26, 2022
0f8d4a7
Add warning for invalid publishsc values
nagilson Oct 27, 2022
159c5d3
Add more precise language to the error
nagilson Oct 31, 2022
4ad49d6
Add the test things
nagilson Nov 1, 2022
244a090
Conclude work on the tests.
nagilson Nov 1, 2022
509598d
Remove BL again
nagilson Nov 1, 2022
a6e5ce0
Remove psc error added in 7.0.2xx merge, and remove changes to testpr…
nagilson Nov 2, 2022
7745b24
Merge remote-tracking branch 'upstream/release/7.0.2xx' into nagilson…
nagilson Nov 4, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions src/Tasks/Common/Resources/Strings.resx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -875,4 +875,8 @@ You may need to build the project on another operating system or architecture, o
<value>NETSDK1192: Targeting .NET 7.0 or higher in Visual Studio 2022 17.3 is not supported.</value>
<comment>{StrBegin="NETSDK1192: "}</comment>
</data>
<data name="PublishSelfContainedMustBeBool" xml:space="preserve">
<value>NETSDK1193: If PublishSelfContained is set, it must be either true or false. The value given was '{0}'.</value>
<comment>{StrBegin="NETSDK1193: "}</comment>
</data>
</root>
5 changes: 5 additions & 0 deletions src/Tasks/Common/Resources/xlf/Strings.cs.xlf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -720,6 +720,11 @@ The following are names of parameters or literal values and should not be transl
<target state="translated">NETSDK1122: Kompilace ReadyToRun se přeskočí, protože se podporuje jen pro architekturu .NET Core 3.0 a vyšší.</target>
<note>{StrBegin="NETSDK1122: "}</note>
</trans-unit>
<trans-unit id="PublishSelfContainedMustBeBool">
<source>NETSDK1193: If PublishSelfContained is set, it must be either true or false. The value given was '{0}'.</source>
<target state="new">NETSDK1193: If PublishSelfContained is set, it must be either true or false. The value given was '{0}'.</target>
<note>{StrBegin="NETSDK1193: "}</note>
</trans-unit>
<trans-unit id="PublishSingleFileRequiresVersion30">
<source>NETSDK1123: Publishing an application to a single-file requires .NET Core 3.0 or higher.</source>
<target state="translated">NETSDK1123: Publikování aplikace do jednoho souboru vyžaduje architekturu .NET Core 3.0 nebo vyšší.</target>
Expand Down
5 changes: 5 additions & 0 deletions src/Tasks/Common/Resources/xlf/Strings.de.xlf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -720,6 +720,11 @@ The following are names of parameters or literal values and should not be transl
<target state="translated">NETSDK1122: Die ReadyToRun-Kompilierung wird übersprungen, weil sie nur für .NET Core 3.0 oder höher unterstützt wird.</target>
<note>{StrBegin="NETSDK1122: "}</note>
</trans-unit>
<trans-unit id="PublishSelfContainedMustBeBool">
<source>NETSDK1193: If PublishSelfContained is set, it must be either true or false. The value given was '{0}'.</source>
<target state="new">NETSDK1193: If PublishSelfContained is set, it must be either true or false. The value given was '{0}'.</target>
<note>{StrBegin="NETSDK1193: "}</note>
</trans-unit>
<trans-unit id="PublishSingleFileRequiresVersion30">
<source>NETSDK1123: Publishing an application to a single-file requires .NET Core 3.0 or higher.</source>
<target state="translated">NETSDK1123: Zum Veröffentlichen einer Anwendung in einer einzelnen Datei ist .NET Core 3.0 oder höher erforderlich.</target>
Expand Down
5 changes: 5 additions & 0 deletions src/Tasks/Common/Resources/xlf/Strings.es.xlf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -720,6 +720,11 @@ The following are names of parameters or literal values and should not be transl
<target state="translated">NETSDK1122: Se omitirá la compilación de ReadyToRun porque solo se admite para .NET Core 3.0 o versiones posteriores.</target>
<note>{StrBegin="NETSDK1122: "}</note>
</trans-unit>
<trans-unit id="PublishSelfContainedMustBeBool">
<source>NETSDK1193: If PublishSelfContained is set, it must be either true or false. The value given was '{0}'.</source>
<target state="new">NETSDK1193: If PublishSelfContained is set, it must be either true or false. The value given was '{0}'.</target>
<note>{StrBegin="NETSDK1193: "}</note>
</trans-unit>
<trans-unit id="PublishSingleFileRequiresVersion30">
<source>NETSDK1123: Publishing an application to a single-file requires .NET Core 3.0 or higher.</source>
<target state="translated">NETSDK1123: La publicación de una aplicación en un único archivo requiere .NET Core 3.0 o versiones posteriores.</target>
Expand Down
5 changes: 5 additions & 0 deletions src/Tasks/Common/Resources/xlf/Strings.fr.xlf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -720,6 +720,11 @@ The following are names of parameters or literal values and should not be transl
<target state="translated">NETSDK1122: la compilation ReadyToRun va être ignorée, car elle est uniquement prise en charge pour .NET Core 3.0 ou une version ultérieure.</target>
<note>{StrBegin="NETSDK1122: "}</note>
</trans-unit>
<trans-unit id="PublishSelfContainedMustBeBool">
<source>NETSDK1193: If PublishSelfContained is set, it must be either true or false. The value given was '{0}'.</source>
<target state="new">NETSDK1193: If PublishSelfContained is set, it must be either true or false. The value given was '{0}'.</target>
<note>{StrBegin="NETSDK1193: "}</note>
</trans-unit>
<trans-unit id="PublishSingleFileRequiresVersion30">
<source>NETSDK1123: Publishing an application to a single-file requires .NET Core 3.0 or higher.</source>
<target state="translated">NETSDK1123: la publication d'une application sur un seul fichier nécessite .NET Core 3.0 ou une version ultérieure.</target>
Expand Down
5 changes: 5 additions & 0 deletions src/Tasks/Common/Resources/xlf/Strings.it.xlf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -720,6 +720,11 @@ The following are names of parameters or literal values and should not be transl
<target state="translated">NETSDK1122: la compilazione eseguita con ReadyToRun verrà ignorata perché è supportata solo per .NET Core 3.0 o versioni successive.</target>
<note>{StrBegin="NETSDK1122: "}</note>
</trans-unit>
<trans-unit id="PublishSelfContainedMustBeBool">
<source>NETSDK1193: If PublishSelfContained is set, it must be either true or false. The value given was '{0}'.</source>
<target state="new">NETSDK1193: If PublishSelfContained is set, it must be either true or false. The value given was '{0}'.</target>
<note>{StrBegin="NETSDK1193: "}</note>
</trans-unit>
<trans-unit id="PublishSingleFileRequiresVersion30">
<source>NETSDK1123: Publishing an application to a single-file requires .NET Core 3.0 or higher.</source>
<target state="translated">NETSDK1123: per la pubblicazione di un'applicazione in un file singolo è richiesto .NET Core 3.0 o versioni successive.</target>
Expand Down
Loading