Skip to content

Conversation

@marcpopMSFT
Copy link
Member

Add loc locked to two of the strings to help the translators and serve as an example going forward

@marcpopMSFT marcpopMSFT requested a review from a team as a code owner October 13, 2022 17:35
@ghost ghost added the Area-Infrastructure label Oct 13, 2022
@nagilson
Copy link
Member

Approved under the assumption that lock terminology is correct. Would it also be easier to tell localization efforts to not translate anything wrapped in `?

<data name="ProjectCapabilityConstraint_Restricted_NotRestored_CTA" xml:space="preserve">
<value>Run 'dotnet restore {0}' to restore the project.</value>
<comment>do not translate 'dotnet restore {0}'</comment>
<comment>{Locked="dotnet restore {0}"}</comment>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With new syntax, would it be automatic processing or still manual?
Otherwise not sure if it's worth replacing old text.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the prior text should not have been used here and it was relying on the translator noticing the text whereas I think the Locked text actually affects the tooling on the loc side.

@cristianosuzuki77 any opinion on fixing old comments with the Locked format?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we have been using the comments like this for quite a time, and it helped to avoid translation issues, so it seems the translators see them easily.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fair enough. I just don't know if the Locked format automatically removes them from the tooling so the exclusion is more automated than manual.

@build-analysis build-analysis bot mentioned this pull request Oct 17, 2022
2 tasks
@marcpopMSFT marcpopMSFT merged commit 46ebdd2 into release/7.0.2xx Oct 20, 2022
@marcpopMSFT marcpopMSFT deleted the marcpopMSFT-addlocignoreexample branch October 20, 2022 19:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants