Improve build stability by ensuring we aren't double publishing everywhere #27899
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
Member
|
I think this looks good. Do you have an official build test that I can peek at? |
Member
|
Double publish is the new double free |
Member
Author
|
@mmitche here's the CI build I ran before cherry-picking over: https://dev.azure.com/dnceng/internal/_build/results?buildId=1993258&view=results |
Member
|
Official looks good. |
Member
Author
|
Had to fix the richnav one but this should be good now. |
mmitche
reviewed
Sep 15, 2022
…r PR builds) so I'm going to go ahead and remove it as a parameter.
Member
Author
|
@mmitche got it passing post PR feedback, ready for review. |
mmitche
approved these changes
Sep 19, 2022
marcpopMSFT
added a commit
that referenced
this pull request
Nov 23, 2022
…ty701xx Improve build stability by ensuring we aren't double publishing everywhere
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.