Skip to content

[main] Update dependencies from dotnet/runtime #27786

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Sep 12, 2022
Merged

[main] Update dependencies from dotnet/runtime #27786

merged 5 commits into from
Sep 12, 2022

Conversation

@dotnet-maestro
Copy link
Contributor

@dotnet-maestro dotnet-maestro bot commented Sep 9, 2022 •
edited
Loading

This pull request updates the following dependencies

From https://github.com/dotnet/runtime

  • Subscription: aa69f164-2492-460a-3914-08d8e9750bf8
  • Build: 20220910.5
  • Date Produced: September 11, 2022 3:44:40 AM UTC
  • Commit: 1f94e11358debe8a9e4804f03939eac535ee41a4
  • Branch: refs/heads/main

@dotnet-maestro
Update dependencies from https://github.com/dotnet/runtime build 2022…
5534a9b 
…0908.22

Microsoft.DotNet.ILCompiler , Microsoft.Extensions.DependencyModel , Microsoft.NET.HostModel , Microsoft.NETCore.App.Host.win-x64 , Microsoft.NETCore.App.Ref , Microsoft.NETCore.App.Runtime.win-x64 , Microsoft.NETCore.DotNetHostResolver , Microsoft.NETCore.Platforms , System.CodeDom , System.Reflection.MetadataLoadContext , System.Resources.Extensions , System.Security.Cryptography.ProtectedData , System.Text.Encoding.CodePages , VS.Redist.Common.NetCore.SharedFramework.x64.8.0 , VS.Redist.Common.NetCore.TargetingPack.x64.8.0
 From Version 8.0.0-alpha.1.22457.17 -> To Version 8.0.0-alpha.1.22458.22
@ghost ghost added the Area-CodeFlow label Sep 9, 2022
@dotnet-maestro
Copy link
Contributor Author

dotnet-maestro bot commented Sep 9, 2022

Notification for subscribed users from https://github.com/dotnet/runtime:

@dnr-codeflow

Action requested: Please take a look at this failing automated dependency-flow pull request's checks; failures may be related to changes which originated in your repo.

  • This pull request contains changes from your source repo (https://github.com/dotnet/runtime) and seems to have failed checks in this PR. Please take a peek at the failures and comment if they seem relevant to your changes.
  • If you're being tagged in this comment it is due to an entry in the related Maestro Subscription of the Build Asset Registry. If you feel this entry has added your GitHub login or your GitHub team in error, please update the subscription to reflect this.
  • For more details, please read the Arcade Darc documentation

@danmoseley
Copy link
Member 

  + ILLink : Trim analysis warning IL2026: Internal.Runtime.InteropServices.InMemoryAssemblyLoader.LoadInMemoryAssemblyInContextWhenSupported(IntPtr, IntPtr): Using member 'Internal.Runtime.InteropServices.InMemoryAssemblyLoader.LoadInMemoryAssemblyInContextImpl(IntPtr, IntPtr, AssemblyLoadContext)' which has 'RequiresUnreferencedCodeAttribute' can break functionality when trimming application code. C++/CLI is not trim-compatible. https://aka.ms/dotnet-illink/nativehost [C:\h\w\A5FC08FD\t\dotnetSdkTests\qgfntwzi.ozy\ILLink_verify---9EAED457\AnalysisWarningsOnHelloWorldApp\AnalysisWarningsOnHelloWorldApp.csproj]

@jkurdek this seems related to dotnet/runtime#73238 ? that change arrives in this PR. could you please look?
eg https://helixre107v0xdeko0k025g8.blob.core.windows.net/dotnet-sdk-refs-pull-27786-merge-188c270db2e843f497/Microsoft.NET.Publish.Tests.dll.5/3/console.4409fb12.log?helixlogtype=result

@dotnet-maestro
Update dependencies from https://github.com/dotnet/runtime build 2022…
ee2c900 
…0909.16

Microsoft.DotNet.ILCompiler , Microsoft.Extensions.DependencyModel , Microsoft.NET.HostModel , Microsoft.NETCore.App.Host.win-x64 , Microsoft.NETCore.App.Ref , Microsoft.NETCore.App.Runtime.win-x64 , Microsoft.NETCore.DotNetHostResolver , Microsoft.NETCore.Platforms , System.CodeDom , System.Reflection.MetadataLoadContext , System.Resources.Extensions , System.Security.Cryptography.ProtectedData , System.Text.Encoding.CodePages , VS.Redist.Common.NetCore.SharedFramework.x64.8.0 , VS.Redist.Common.NetCore.TargetingPack.x64.8.0
 From Version 8.0.0-alpha.1.22457.17 -> To Version 8.0.0-alpha.1.22459.16
@dotnet-maestro
Update dependencies from https://github.com/dotnet/runtime build 2022…
0dfcd0a 
…0910.5

Microsoft.DotNet.ILCompiler , Microsoft.Extensions.DependencyModel , Microsoft.NET.HostModel , Microsoft.NETCore.App.Host.win-x64 , Microsoft.NETCore.App.Ref , Microsoft.NETCore.App.Runtime.win-x64 , Microsoft.NETCore.DotNetHostResolver , Microsoft.NETCore.Platforms , System.CodeDom , System.Reflection.MetadataLoadContext , System.Resources.Extensions , System.Security.Cryptography.ProtectedData , System.Text.Encoding.CodePages , VS.Redist.Common.NetCore.SharedFramework.x64.8.0 , VS.Redist.Common.NetCore.TargetingPack.x64.8.0
 From Version 8.0.0-alpha.1.22457.17 -> To Version 8.0.0-alpha.1.22460.5
@kasperk81
Copy link
Contributor

changing

sdk/src/Tests/Microsoft.NET.Publish.Tests/GivenThatWeWantToRunILLink.cs

Line 651 in 459df26

"ILLink : Trim analysis warning IL2026: Internal.Runtime.InteropServices.InMemoryAssemblyLoader.LoadInMemoryAssembly(IntPtr, IntPtr",

to

 "ILLink : Trim analysis warning IL2026: Internal.Runtime.InteropServices.InMemoryAssemblyLoader.LoadInMemoryAssemblyInContextWhenSupported(IntPtr, IntPtr",

should fix the error

@jkurdek
Copy link

jkurdek commented Sep 12, 2022

In dotnet/runtime#73238, we moved the RUC annonated LoadInMemoryAssemblyInContextImpl into a separate method in order to reduce the scope of suppression. The IL2026 warning is now issued on LoadInMemoryAssemblyInContextWhenSupported. Change suggested by @kasperk81 should fix the problem.

The same change has to be applied to the other failing test

sdk/src/Tests/Microsoft.NET.Publish.Tests/GivenThatWeWantToRunILLink.cs

Line 678 in 459df26

"ILLink : Trim analysis warning IL2026: Internal.Runtime.InteropServices.InMemoryAssemblyLoader.LoadInMemoryAssembly(IntPtr, IntPtr",

to

 "ILLink : Trim analysis warning IL2026: Internal.Runtime.InteropServices.InMemoryAssemblyLoader.LoadInMemoryAssemblyInContextWhenSupported(IntPtr, IntPtr",

/cc @vitek-karas

@jkurdek
Copy link

jkurdek commented Sep 12, 2022

Accounted for changes introduced in dotnet/runtime#73238 and dotnet/runtime#75176.

/cc @eerhardt

@dotnet-maestro dotnet-maestro bot merged commit f4c8f6f into main Sep 12, 2022
@dotnet-maestro dotnet-maestro bot deleted the darc-main-59ce0823-2380-41c4-a24d-48b3eca43fff branch September 12, 2022 12:53
@kasperk81 kasperk81 mentioned this pull request Sep 13, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

Area-CodeFlow

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@danmoseley @kasperk81 @jkurdek