Skip to content

[release/6.0.4xx] Update dependencies from dotnet/roslyn #26629

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 18, 2022
Merged

[release/6.0.4xx] Update dependencies from dotnet/roslyn #26629

merged 2 commits into from
Jul 18, 2022
+18 −18

Conversation

@dotnet-maestro
Copy link
Contributor

@dotnet-maestro dotnet-maestro bot commented Jul 16, 2022 •
edited
Loading

This pull request updates the following dependencies

From https://github.com/dotnet/roslyn

  • Subscription: 79e3bb73-6e4a-4575-9262-08da1816542b
  • Build: 20220715.10
  • Date Produced: July 16, 2022 3:39:25 AM UTC
  • Commit: dd078d4e43fca042188bafc4548e6fe2abb62250
  • Branch: refs/heads/release/dev17.3-vs-deps

@dotnet-maestro
Update dependencies from https://github.com/dotnet/roslyn build 20220…
6b5c1b6 
…715.7

Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.CodeAnalysis.CSharp.Features , Microsoft.CodeAnalysis.CSharp.Workspaces , Microsoft.CodeAnalysis.Workspaces.MSBuild , Microsoft.Net.Compilers.Toolset
 From Version 4.3.0-3.22363.19 -> To Version 4.3.0-3.22365.7
@ghost ghost added the Area-CodeFlow label Jul 16, 2022
@dotnet-maestro
Update dependencies from https://github.com/dotnet/roslyn build 20220…
b12a972 
…715.10

Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.CodeAnalysis.CSharp.Features , Microsoft.CodeAnalysis.CSharp.Workspaces , Microsoft.CodeAnalysis.Workspaces.MSBuild , Microsoft.Net.Compilers.Toolset
 From Version 4.3.0-3.22363.19 -> To Version 4.3.0-3.22365.10
@v-wuzhai v-wuzhai merged commit 0c31d79 into release/6.0.4xx Jul 18, 2022
@v-wuzhai v-wuzhai deleted the darc-release/6.0.4xx-dbd084ce-eeb7-4fbb-9816-d82b10e18e28 branch July 18, 2022 03:14
@marcpopMSFT
Copy link
Member

marcpopMSFT commented Jul 18, 2022

@jaredpar , this is not in the 6.0.400 build we're trying to prep for release. Is the change from Roslyn needed in 6.0.400? Looks like test and loc changes from what I can tell but I may not have found the right commit diff.

@jaredpar
Copy link
Member

jaredpar commented Jul 18, 2022

@marcpopMSFT if this is the right commit diff then it's fine to not have this.

How do we know if it's the right commit diff? I just click on the links in the PR. If they're not right, I'm not sure how to investigate this.

@marcpopMSFT
Copy link
Member

marcpopMSFT commented Jul 18, 2022

@jaredpar we can look at the commit for the prior build to the new build. This PR goes from build 713.19 build to 715.10:
https://dev.azure.com/dnceng/internal/_build?definitionId=327&branchFilter=231000%2C231000

From history, that goes from hash 8b86c2058266c6069e71705623fe9f3b26b648cf to dd078d4e43fca042188bafc4548e6fe2abb62250 which is how the bot set up the commit diff. Staring at commit history, I think GH is showing us the right thing and we don't need this change.

@jaredpar
Copy link
Member

jaredpar commented Jul 18, 2022

Sounds good.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@v-wuzhai v-wuzhai v-wuzhai approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Area-CodeFlow

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@marcpopMSFT @jaredpar @v-wuzhai