Allow dotnet workload update print-download-link-only to use fallback and work with prior SDK versions #26369
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…printDownloadLinkWithPriorSdkVersions
ghost
added
the
nagilson
reviewed
Jun 29, 2022
src/Cli/dotnet/NugetPackageDownloader/NuGetPackageDownloader.cs
Outdated
Show resolved
Hide resolved
joeloff
reviewed
Jun 30, 2022
joeloff
reviewed
Jun 30, 2022
src/Cli/dotnet/commands/dotnet-workload/install/WorkloadManifestUpdater.cs
Outdated
Show resolved
Hide resolved
joeloff
reviewed
Jun 30, 2022
src/Cli/dotnet/commands/dotnet-workload/install/WorkloadManifestUpdater.cs
Outdated
Show resolved
Hide resolved
joeloff
reviewed
Jun 30, 2022
src/Cli/dotnet/commands/dotnet-workload/install/WorkloadManifestUpdater.cs
Outdated
Show resolved
Hide resolved
joeloff
reviewed
Jun 30, 2022
joeloff
reviewed
Jun 30, 2022
src/Layout/toolset-tasks/OverrideAndCreateBundledNETCoreAppPackageVersion.cs
Outdated
Show resolved
Hide resolved
joeloff
reviewed
Jun 30, 2022
src/Resolvers/Microsoft.NET.Sdk.WorkloadManifestReader/SdkDirectoryWorkloadManifestProvider.cs
Outdated
Show resolved
Hide resolved
joeloff
reviewed
Jun 30, 2022
src/Tests/dotnet-workload-install.Tests/GivenWorkloadManifestUpdater.cs
Outdated
Show resolved
Hide resolved
nagilson
requested changes
Jun 30, 2022
Member
nagilson
left a comment
nagilson
left a comment
There was a problem hiding this comment.
In response to earlier comment, provided more targeted feedback
src/Cli/dotnet/NugetPackageDownloader/NuGetPackageDownloader.cs
Outdated
Show resolved
Hide resolved
src/Cli/dotnet/commands/dotnet-workload/install/WorkloadManifestUpdater.cs
Show resolved
Hide resolved
src/Cli/dotnet/commands/dotnet-workload/install/WorkloadOptionsExtensions.cs
Show resolved
Hide resolved
src/Cli/dotnet/commands/dotnet-workload/install/WorkloadManifestUpdater.cs
Show resolved
Hide resolved
nagilson
approved these changes
Jun 30, 2022
dsplaisted
reviewed
Jul 5, 2022
src/Cli/dotnet/commands/dotnet-workload/install/WorkloadManifestUpdater.cs
Outdated
Show resolved
Hide resolved
| { | ||
| try | ||
| { | ||
|
|
Member
There was a problem hiding this comment.
We should update UpdateAdvertisingManifestAsync so that it calls GetManifestPackageDownloadsAsync instead of having the logic duplicated.
src/Cli/dotnet/commands/dotnet-workload/install/WorkloadManifestUpdater.cs
Outdated
Show resolved
Hide resolved
src/Resolvers/Microsoft.NET.Sdk.WorkloadManifestReader/SdkDirectoryWorkloadManifestProvider.cs
Outdated
Show resolved
Hide resolved
src/Tests/dotnet-workload-update.Tests/GivenDotnetWorkloadUpdate.cs
Outdated
Show resolved
Hide resolved
…s passed in from command line
joeloff
reviewed
Jul 14, 2022
joeloff
approved these changes
Jul 15, 2022
Member
|
Approved offline, fingers crossed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #24335
Description
The VSMac updater calls the prior band SDK and asks it which workloads to install with the current feature band. The feature was originally designed to work with only the current band and not cross-band and this change fixes it to work that way.
Customer Impact
Without this change, VSMac customers who upgrade will not be told on their initial upgrade that there are workloads that require updates. They will be forced to either drop to the command line and manually update workloads or wait for a future update that may or may not work depending on if it's a patch update or not.
Regression?
Risk
The change itself is a bit bigger but it's affect is almost entirely in the --print-downlaod-linke-only feature of the workloads CLI. This command is only used by VSMac and it's completely broken today.
Verification
We have not tested with VSMac yet as we need either an official build with newer workloads or to backport this to 6.0.3xx.