[main] Update dependencies from dotnet/windowsdesktop

[dotnet-maestro]

This pull request updates the following dependencies

From https://github.com/dotnet/windowsdesktop

• Subscription: 43b77b68-0b3c-49dd-3915-08d8e9750bf8
• Build: 20220111.7
• Date Produced: January 12, 2022 7:20:51 AM UTC
• Commit: 6dafa8ec11b41ae4696214f5ba23d06eb211f0de
• Branch: refs/heads/main

• Updates:
  • VS.Redist.Common.WindowsDesktop.TargetingPack.x64.7.0: from 7.0.0-alpha.1.22055.1 to 7.0.0-alpha.1.22061.7
  • VS.Redist.Common.WindowsDesktop.SharedFramework.x64.7.0: from 7.0.0-alpha.1.22055.1 to 7.0.0-alpha.1.22061.7
  • Microsoft.WindowsDesktop.App.Runtime.win-x64: from 7.0.0-alpha.1.22055.1 to 7.0.0-alpha.1.22061.7
  • Microsoft.WindowsDesktop.App.Ref: from 7.0.0-alpha.1.22055.1 to 7.0.0-alpha.1.22061.7
  • Microsoft.NET.Sdk.WindowsDesktop: from 7.0.0-alpha.1.22055.1 to 7.0.0-alpha.1.22061.9

Coherency Updates

The following updates ensure that dependencies with a CoherentParentDependency
attribute were produced in a build used as input to the parent dependency's build.
See Dependency Description Format

• Coherency Updates:
  • Microsoft.NET.Sdk.WindowsDesktop: from 7.0.0-alpha.1.22055.1 to 7.0.0-alpha.1.22061.9 (parent: Microsoft.WindowsDesktop.App.Ref)

[dotnet-maestro]

Notification for subscribed users from https://github.com/dotnet/windowsdesktop:

@dotnet/wpf-developers

Action requested: Please take a look at this failing automated dependency-flow pull request's checks; failures may be related to changes which originated in your repo.

• This pull request contains changes from your source repo (https://github.com/dotnet/windowsdesktop) and seems to have failed checks in this PR. Please take a peek at the failures and comment if they seem relevant to your changes.
• If you're being tagged in this comment it is due to an entry in the related Maestro Subscription of the Build Asset Registry. If you feel this entry has added your GitHub login or your GitHub team in error, please update the subscription to reflect this.
• For more details, please read the Arcade Darc documentation

[dreddy-work]

@pranavkm / @mmitche , do you have any idea on these failures? i couldn't locate the logs for failed tests here.

[mmitche]

@pranavkm / @mmitche , do you have any idea on these failures? i couldn't locate the logs for failed tests here.

Look under Artifacts tab for some of the tests. There are console logs there and it looks like timeouts or test hangs. There are also some tests where it couldn't locate PresentationFramework.dll

[dreddy-work]

Some tests failed with following. It seems its looking for PresentationBuildTasks.dll in 6.0 folder.

C:\h\w\A8AF0953\p\d\sdk\7.0.100-ci\Sdks\Microsoft.NET.Sdk.WindowsDesktop\targets\Microsoft.WinFX.targets(211,9): error MSB4062: The "Microsoft.Build.Tasks.Windows.MarkupCompilePass1" task could not be loaded from the assembly C:\h\w\A8AF0953\p\d\sdk\7.0.100-ci\Sdks\Microsoft.NET.Sdk.WindowsDesktop\tools\net6.0\PresentationBuildTasks.dll. Could not load file or assembly 'C:\h\w\A8AF0953\p\d\sdk\7.0.100-ci\Sdks\Microsoft.NET.Sdk.WindowsDesktop\tools\net6.0\PresentationBuildTasks.dll'. The system cannot find the path specified. Confirm that the declaration is correct, that the assembly and all its dependencies are available, and that the task contains a public class that implements Microsoft.Build.Framework.ITask. [C:\h\w\A8AF0953\t\dotnetSdkTests\mca1j10r.tgn\It_publishes_---F395A6ED\It_publishes_---F395A6ED.csproj]

[dreddy-work]

adding @singhashish-wpf / @vishalmsft to look at wpf failures here.

[dreddy-work]

Build tests seems failing with following reason:

< C:\Repos\sdk\artifacts\tmp\Debug\net5.0Compila---8A3BB383\CompilationConstants\bin\Debug\net5.0\CompilationConstants.exe exited with 0 in 676 ms.
Microsoft.NET.Build.Tests.GivenThatWeWantToBuildALibrary.It_defines_target_platform_defaults_correctly [SKIP]
Failed to determine the version required by this test (16.7.0-preview-20310-07).

and

C:\h\w\AA8F08D9\p\d\sdk\7.0.100-ci\Sdks\Microsoft.NET.Sdk.WindowsDesktop\targets\Microsoft.WinFX.targets(211,9): error MSB4062: The "Microsoft.Build.Tasks.Windows.MarkupCompilePass1" task could not be loaded from the assembly C:\h\w\AA8F08D9\p\d\sdk\7.0.100-ci\Sdks\Microsoft.NET.Sdk.WindowsDesktop\tools\net6.0\PresentationBuildTasks.dll. Could not load file or assembly 'C:\h\w\AA8F08D9\p\d\sdk\7.0.100-ci\Sdks\Microsoft.NET.Sdk.WindowsDesktop\tools\net6.0\PresentationBuildTasks.dll'. The system cannot find the path specified. Confirm that the declaration is correct, that the assembly and all its dependencies are available, and that the task contains a public class that implements Microsoft.Build.Framework.ITask. [C:\h\w\AA8F08D9\t\dotnetSdkTests\nwnyhutz.f45\It_builds_suc---1E1E42EA\It_builds_suc---1E1E42EA.csproj]
StdErr:

[dreddy-work]

I see PresentationBuildTasks.dll generated at relative path *\Sdks\Microsoft.NET.Sdk.WindowsDesktop\tools\net6.0\PresentationBuildTasks.dll on the build machine but not sure why it cannot load. Assuming above path on build machine map to absolute path C:\h\w\AA8F08D9\p\d\sdk\7.0.100-ci\Sdks\Microsoft.NET.Sdk.WindowsDesktop\tools\net6.0\PresentationBuildTasks.dll, as shown in above error message. Tagging @dsplaisted and @dotnet/wpf-developers to help unblock this. @singhashish-wpf / @vishalmsft . For my understanding, why PresentationBuildTasks.dll generated under *\net6.0\* and targeting .net6.0 has the assembly and file versions 7.0.* ?

[singhashish-wpf]

The PresentationBuildTasks.dll is getting picked up from 6.0 folder, which seems bad because WPF repo's main branch is targeting 7(i.e targetframework is 7) and it should instead get it from 7.0 IMO.
This seems to be because of NuGetBuildTasksPackageVersion defined below:

sdk/eng/Versions.props

Line 58 in 4f660c4

<NuGetBuildTasksPackageVersion>6.0.0-rc.278</NuGetBuildTasksPackageVersion>

@dsplaisted @mmitche
Can this be updated or is there something I am missing here?

[dsplaisted]

@dreddy-work I don't think this has anything to do with the NuGet Build Tasks version. I think the issue is that in the WPF repo there is a mismatch of the TargetFramework used to create the package and to locate the task DLL:

https://github.com/dotnet/wpf/blob/3509e0aa0558c82d2aecad2041c8f4553fe0b036/src/Microsoft.DotNet.Wpf/src/PresentationBuildTasks/Microsoft.WinFX.targets#L4

https://github.com/dotnet/wpf/blob/3509e0aa0558c82d2aecad2041c8f4553fe0b036/src/Microsoft.DotNet.Wpf/src/PresentationBuildTasks/PresentationBuildTasks.csproj#L3

I think Microsoft.WinFX.targets needs to be updated to specify net7.0. Ideally both values would come from the same place and only need to be updated once, but that's not necessary to unblock this here.