Configure DOTNET_ROOT when running apps #16687
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The runtime uses DOTNET_ROOT to locate the .NET runtime. When unspecified, the CLI will continue to use the runtime from the global default. If you install dotnet to a location, configure the PATH, but not the runtime then you end up running in to issues where it complains about missing runtime.
|
I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label. |
captainsafia
approved these changes
Apr 1, 2021
jkotalik
reviewed
Apr 1, 2021
| processSpec.EnvironmentVariables["ASPNETCORE_URLS"] = context.DefaultLaunchSettingsProfile.ApplicationUrl; | ||
| } | ||
|
|
||
| var rootVariableName = Environment.Is64BitProcess ? "DOTNET_ROOT" : "DOTNET_ROOT(x86)"; |
Contributor
There was a problem hiding this comment.
Is that really the name of the x86 root? That feels different that from what I remember.
Contributor
Author
There was a problem hiding this comment.
jkotalik
approved these changes
Apr 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The runtime uses DOTNET_ROOT to locate the .NET runtime. When unspecified,
the CLI will continue to use the runtime from the global default.
If you install dotnet to a location, configure the PATH, but not the runtime
then you end up running in to issues where it complains about missing runtime.
Separately make sure we're only configuring process variables once. They remain unchanged for the lifetime of hot reload so it's just additional code that does not need to run.