-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Fix Blazor WASM SDK packaging and backport fix #14968
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
087cedd to
ca15375
Compare
ca15375 to
ca051cd
Compare
c8b40c4 to
2acd02c
Compare
b5c6daa to
5d82054
Compare
5d82054 to
8ed6b29
Compare
wli3
reviewed
Dec 16, 2020
...s/Microsoft.NET.Sdk.BlazorWebAssembly.Tests/Microsoft.NET.Sdk.BlazorWebAssembly.Tests.csproj
Outdated
Show resolved
Hide resolved
wli3
reviewed
Dec 16, 2020
...s/Microsoft.NET.Sdk.BlazorWebAssembly.Tests/Microsoft.NET.Sdk.BlazorWebAssembly.Tests.csproj
Outdated
Show resolved
Hide resolved
|
also could you update the CODEOWNERS. Instead of your name, replace it with your team's alias? |
pranavkm
reviewed
Dec 17, 2020
src/BlazorWasmSdk/Tasks/Microsoft.NET.Sdk.BlazorWebAssembly.Tasks.csproj
Outdated
Show resolved
Hide resolved
src/BlazorWasmSdk/Tasks/Microsoft.NET.Sdk.BlazorWebAssembly.Tasks.csproj
Show resolved
Hide resolved
src/BlazorWasmSdk/Tasks/Microsoft.NET.Sdk.BlazorWebAssembly.Tasks.csproj
Show resolved
Hide resolved
src/BlazorWasmSdk/Targets/Microsoft.NET.Sdk.BlazorWebAssembly.Current.targets
Show resolved
Hide resolved
src/BlazorWasmSdk/Tasks/Microsoft.NET.Sdk.BlazorWebAssembly.Tasks.csproj
Outdated
Show resolved
Hide resolved
src/BlazorWasmSdk/Tasks/Microsoft.NET.Sdk.BlazorWebAssembly.Tasks.csproj
Outdated
Show resolved
Hide resolved
src/BlazorWasmSdk/Tasks/Microsoft.NET.Sdk.BlazorWebAssembly.Tasks.csproj
Show resolved
Hide resolved
Member
Author
|
@wli3 Post-holiday bump on this PR. |
wli3
approved these changes
Jan 4, 2021
|
@captainsafia also need an approval from your team member |
|
@captainsafia and from now on, if you don't think a change to Blazor WASM would affect SDK, you don't need my team's approval. Since these code belong to your team in the end. |
pranavkm
approved these changes
Jan 4, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes in this PR
This PR has a couple of changes to get the dev SDK hooked up correctly and to backport a fix from the ASP.NET Core repo. Below is a guideline for the changes in the PR.
Remove BlazorWebAssembly SDK from list of bundled SDKs to ensure the version in the repo is used not a globally installed one
Add targets for Blazor WASM SDK to solution file
Fix references to tools and tasks in target file to match new layout
Fixed up layout generation for tasks
Made sure that
System.CommandLinedependency was copied over into toolEnsure the Blazor WASM tool is published before the SDK
Update test project file to ensure that project-level test targets can run
Backport fix from dotnet/aspnetcore#28539 to the SDK here