Skip to content

Conversation

@captainsafia
Copy link
Member

@captainsafia captainsafia commented Dec 14, 2020

Changes in this PR

This PR has a couple of changes to get the dev SDK hooked up correctly and to backport a fix from the ASP.NET Core repo. Below is a guideline for the changes in the PR.

Remove BlazorWebAssembly SDK from list of bundled SDKs to ensure the version in the repo is used not a globally installed one

Add targets for Blazor WASM SDK to solution file

Fix references to tools and tasks in target file to match new layout

Fixed up layout generation for tasks

Made sure that System.CommandLine dependency was copied over into tool

Ensure the Blazor WASM tool is published before the SDK

Update test project file to ensure that project-level test targets can run

Backport fix from dotnet/aspnetcore#28539 to the SDK here

@captainsafia captainsafia force-pushed the safia/backport-blazorwasm-sdk-pr branch 2 times, most recently from 087cedd to ca15375 Compare December 15, 2020 05:22
@captainsafia captainsafia force-pushed the safia/backport-blazorwasm-sdk-pr branch from ca15375 to ca051cd Compare December 15, 2020 05:30
@captainsafia captainsafia force-pushed the safia/backport-blazorwasm-sdk-pr branch from c8b40c4 to 2acd02c Compare December 16, 2020 00:04
@captainsafia captainsafia removed the request for review from vijayrkn December 16, 2020 00:40
@captainsafia captainsafia force-pushed the safia/backport-blazorwasm-sdk-pr branch 3 times, most recently from b5c6daa to 5d82054 Compare December 16, 2020 17:36
@captainsafia captainsafia force-pushed the safia/backport-blazorwasm-sdk-pr branch from 5d82054 to 8ed6b29 Compare December 16, 2020 17:47
@captainsafia captainsafia requested a review from wli3 December 16, 2020 19:42
@wli3
Copy link

wli3 commented Dec 17, 2020

also could you update the CODEOWNERS. Instead of your name, replace it with your team's alias?

@captainsafia
Copy link
Member Author

@wli3 Post-holiday bump on this PR.

@wli3
Copy link

wli3 commented Jan 4, 2021

@captainsafia also need an approval from your team member

@wli3
Copy link

wli3 commented Jan 4, 2021

@captainsafia and from now on, if you don't think a change to Blazor WASM would affect SDK, you don't need my team's approval. Since these code belong to your team in the end.

@captainsafia captainsafia merged commit 1c4638b into master Jan 4, 2021
@mmitche mmitche deleted the safia/backport-blazorwasm-sdk-pr branch January 28, 2021 18:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants