Skip to content

Source dependency on Microsoft.DotNet.SdkResolver #13311

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
1 commit merged into from
Sep 2, 2020
Merged

Source dependency on Microsoft.DotNet.SdkResolver #13311

1 commit merged into from
Sep 2, 2020

Conversation

@wli3
Copy link

@wli3 wli3 commented Sep 1, 2020

No description provided.

@wli3 wli3 added the tell-mode label Sep 1, 2020
dsplaisted
dsplaisted approved these changes Sep 1, 2020
View reviewed changes
src/Resolvers/Microsoft.DotNet.MSBuildSdkResolver/Microsoft.DotNet.MSBuildSdkResolver.csproj
</ItemGroup>

</Project>
<ItemGroup Condition="'$(TargetFrameworkIdentifier)' == '.NETFramework'">
Copy link
Member

@dsplaisted dsplaisted Sep 1, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is all copied (and now duplicated from) the Microsoft.DotNet.SdkResolver project, right?

Copy link
Author

@wli3 wli3 Sep 1, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes

...s/Microsoft.DotNet.MSBuildSdkResolver.Tests/Microsoft.DotNet.MSBuildSdkResolver.Tests.csproj
<ProjectReference Include="..\..\Resolvers\Microsoft.DotNet.SdkResolver\Microsoft.DotNet.SdkResolver.csproj" />

<!-- Microsoft.DotNet.MSBuildSdkResolver compiles source of Microsoft.DotNet.SdkResolver to reduce dll load. There are duplicated types-->
<ProjectReference Include="..\..\Resolvers\Microsoft.DotNet.SdkResolver\Microsoft.DotNet.SdkResolver.csproj">
Copy link
Member

@dsplaisted dsplaisted Sep 1, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to reference the DLLs from both types? Should we just reference the MSBuildSdkResolver project and use the types from it?

Copy link
Author

@wli3 wli3 Sep 1, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I need to reuse the setup of testing msbuildsdkresolver to test template locator's finding VS version function. It is too much to duplicate, so i just added the template locator test in msbuildsdkresolver tests. And a type from template locator's dependency chain is used in the test. So i need Microsoft.DotNet.SdkResolver too

@wli3 wli3 added auto-merge Automatically merge PR once CI passes. Auto-Merge If Tests Pass labels Sep 1, 2020
@ghost
Copy link

ghost commented Sep 1, 2020

Hello @wli3!

Because this pull request has the Auto-Merge If Tests Pass label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

@ghost ghost merged commit c6e0ecd into dotnet:release/5.0.1xx Sep 2, 2020
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dsplaisted dsplaisted dsplaisted approved these changes

@joeloff joeloff joeloff approved these changes

@sfoslund sfoslund Awaiting requested review from sfoslund

Assignees

No one assigned

Labels

Auto-Merge If Tests Pass auto-merge Automatically merge PR once CI passes.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@wli3 @dsplaisted @joeloff