Skip to content

Conversation

@wli3
Copy link

@wli3 wli3 commented Jul 21, 2020

Please review by commits. There are several refactoring leading up to it

@wli3 wli3 requested review from dsplaisted and sfoslund and removed request for sfoslund July 21, 2020 17:37
@sfoslund
Copy link
Member

@wli3 is this an alternative implementation of #12456 (I have another PR out for this here #12547) or am I misunderstanding?

@wli3
Copy link
Author

wli3 commented Jul 21, 2020

@sfoslund oh shoot. I also have an issue with the same task (it is gone somehow). Well. I do prefer to generate it from known framework reference instead of a duplicated entry. But your are first. Let's use yours

@wli3 wli3 closed this Jul 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants