Skip to content

[Preview 8] [WebSDK] Only include the existent tooling files to the None glob #12533

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 20, 2020
Merged

[Preview 8] [WebSDK] Only include the existent tooling files to the None glob #12533

merged 1 commit into from
Jul 20, 2020

Conversation

@vijayrkn
Copy link
Contributor

@vijayrkn vijayrkn commented Jul 17, 2020

Fixes #12529

@vijayrkn vijayrkn requested review from BillHiebert and pranavkm July 17, 2020 02:48
@vijayrkn vijayrkn force-pushed the vramak/FixSDGlobIssue branch from 52ab45a to aac822b Compare July 19, 2020 17:42
@vijayrkn vijayrkn linked an issue Jul 20, 2020 that may be closed by this pull request
[WebSDK] None glob should not include non-existent files #12529
Closed
@vijayrkn
Copy link
Contributor Author

vijayrkn commented Jul 20, 2020

PR: #12533
Issue : #12529

Summary:

In preview8, a change was made to update the glob for the tooling files from content to none so that incremental build will not get triggered for tooling artifact changes (perf improvement). Functionally build and publish works correctly with his change but Visual studio started showing non-existent files in the solution explorer (with a deleted icon). The change is to fix this behavior and only show existent files in the solution explorer.

Customer Impact

With Preview 8 installed, customers will start seeing non-existent tooling files listed in the solution explorer (with a deleted icon) even when the files are not present.

Regression?

The issue was introduced in a change available in preview8 (#12461).

Testing

Tested the functionality in Visual Studio and correct files are displayed in the solution explorer.

Risk

Low.

@vijayrkn vijayrkn requested a review from BillHiebert July 20, 2020 15:17
@vijayrkn vijayrkn merged commit 2a3755a into release/5.0.1xx-preview8 Jul 20, 2020
@vijayrkn vijayrkn deleted the vramak/FixSDGlobIssue branch July 21, 2020 21:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pranavkm pranavkm Awaiting requested review from pranavkm

1 more reviewer

@BillHiebert BillHiebert BillHiebert approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Area-WebSDK Servicing-approved

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[WebSDK] None glob should not include non-existent files

3 participants

@vijayrkn @BillHiebert