Skip to content

Backwards compatibility for target platform compilation constants #12124

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jul 1, 2020
Merged

Backwards compatibility for target platform compilation constants #12124

merged 4 commits into from
Jul 1, 2020

Conversation

@sfoslund
Copy link
Member

@sfoslund sfoslund commented Jun 22, 2020 •
edited
Loading

Fixes #11236

@sfoslund sfoslund requested review from dsplaisted, joeloff and wli3 June 22, 2020 18:38
@wli3
Copy link

wli3 commented Jun 25, 2020

Sorry for the delay

@sfoslund
Copy link
Member Author

sfoslund commented Jun 29, 2020

@dsplaisted I think I've made all the changes you suggested, let me know if there's anything I missed.

@sfoslund sfoslund merged commit b865dde into dotnet:master Jul 1, 2020
@sfoslund sfoslund deleted the PreproSymbols branch July 1, 2020 21:04
@sfoslund
Copy link
Member Author

sfoslund commented Jul 14, 2020

@dsplaisted @wli3 This change hardcoded SupportedTargetPlatform into the test. Is there work being tracked that will add the real SupportedTargetPlatform item group?

@dsplaisted dsplaisted mentioned this pull request Jul 14, 2020
Closed
@dsplaisted
Copy link
Member

dsplaisted commented Jul 14, 2020

@sfoslund I've filed #12456 for adding SupportedTargetPlatform items (and generating an error if an invalid version is targeted).

@sfoslund sfoslund mentioned this pull request Sep 11, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dsplaisted dsplaisted dsplaisted approved these changes

@joeloff joeloff Awaiting requested review from joeloff

+1 more reviewer

@wli3 wli3 wli3 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Automatically define preprocessor symbols for target platforms

3 participants

@sfoslund @wli3 @dsplaisted