dotnet pack doesn't generate XML docs

[victorhurdugaci]

dnu pack used to generate xml docs. It seems that dotnet pack doesn't do the same.

Unless I'm missing something, there doesn't seem to be any way to get xml docs generated with dotnet.

cc @anurse @davidfowl

[davidfowl]

Good catch! We should probably implement #4459 as part of this.

/cc @pakrym @agocke @jaredpar

[analogrelay]

This was actually already working, dotnet-compile just wasn't generating the XML file. Once #4459 was fixed this came for free.

[victorhurdugaci]

@ajaybhargavb can you please check, once the build completes, that this one fixes the nuget verifier? It should pass now

[ajaybhargavb]

I just tried building Common repo. It still doesn't generate the XML files. @anurse could you please check if the latest build has the fix?

[analogrelay]

Figured this out in person, we need to set compilationOptions.xmlDoc to true in the project.json. As in https://github.com/dotnet/cli/blob/master/test/TestProjects/TestLibrary/project.json