Microsoft.NET.Sdk imports CustomBeforeDirectoryBuildProps after DirectoryBuildPropsPath

[tmds]

Microsoft.Common.props (from dotnet/msbuild) has these imports surrounding DirectoryBuildPropsPath:

  <Import Project="$(CustomBeforeDirectoryBuildProps)" Condition="'$(CustomBeforeDirectoryBuildProps)' != ''" />

  <Import Project="$(DirectoryBuildPropsPath)" Condition="'$(ImportDirectoryBuildProps)' == 'true' and exists('$(DirectoryBuildPropsPath)')"/>

  <Import Project="$(CustomAfterDirectoryBuildProps)" Condition="'$(CustomAfterDirectoryBuildProps)' != ''" />

Sdk.props handles DirectoryBuildPropsPath early:

sdk/src/Tasks/Microsoft.NET.Build.Tasks/sdk/Sdk.props

Lines 54 to 58 in 82444e0

	<Import Project="$(DirectoryBuildPropsPath)" Condition="'$(ImportDirectoryBuildProps)' == 'true' and exists('$(DirectoryBuildPropsPath)')"/>
	<PropertyGroup>
	<ImportDirectoryBuildProps>false</ImportDirectoryBuildProps>
	</PropertyGroup>

This doesn't consider CustomBeforeDirectoryBuildProps, which causes DirectoryBuildPropsPath to get imported before CustomBeforeDirectoryBuildProps.

cc @dsplaisted

[dsplaisted]

We added those custom properties as a hook for the SDK to use (so the SDK itself wouldn't have to dupicate the Directory.Build.props import logic), but never updated the SDK itself to take advantage of the hook.

@Forgind, would you be able to take a look at this sometime?

FYI @marcpopMSFT

[Forgind]

Good catch @tmds. I can make a PR into MSBuild to add the same logic around that location.

[Forgind]

#36777