-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Closed
Labels
Milestone
Description
In order to get OmniSharp working with a source-built .NET SDK, we need to build Microsoft.NET.Build.Tasks for netfx. However, we have some code that explicitly removes these assemblies from building for netfx:
| <TargetFrameworks>$(SdkTargetFramework);net472</TargetFrameworks> | |
| <TargetFrameworks Condition=" '$(DotNetBuildFromSource)' == 'true' ">$(SdkTargetFramework)</TargetFrameworks> |
sdk/src/Tasks/Microsoft.NET.Build.Extensions.Tasks/Microsoft.NET.Build.Extensions.Tasks.csproj
Lines 18 to 19 in 7bffe25
| <TargetFrameworks>$(SdkTargetFramework);net472</TargetFrameworks> | |
| <TargetFrameworks Condition=" '$(DotNetBuildFromSource)' == 'true' ">$(SdkTargetFramework)</TargetFrameworks> |
This causes OmniSharp to not work with a 6.0 source-built SDK.
In order to work around this for source-build, we are introducing a patch for 6.0.0. We should port these patches into the dotnet/sdk repo proper.