Skip to content

Port dotnet/sdk SourceBuild patches from dotnet/installer #22281

@eerhardt

Description

@eerhardt

In order to get OmniSharp working with a source-built .NET SDK, we need to build Microsoft.NET.Build.Tasks for netfx. However, we have some code that explicitly removes these assemblies from building for netfx:

<TargetFrameworks>$(SdkTargetFramework);net472</TargetFrameworks>
<TargetFrameworks Condition=" '$(DotNetBuildFromSource)' == 'true' ">$(SdkTargetFramework)</TargetFrameworks>

<TargetFrameworks>$(SdkTargetFramework);net472</TargetFrameworks>
<TargetFrameworks Condition=" '$(DotNetBuildFromSource)' == 'true' ">$(SdkTargetFramework)</TargetFrameworks>

This causes OmniSharp to not work with a 6.0 source-built SDK.

In order to work around this for source-build, we are introducing a patch for 6.0.0. We should port these patches into the dotnet/sdk repo proper.

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions