Duplicate entries in ResolvedFileToPublish from ReferenceAssemblies and Content

[jkotas]

Description

1. Unzip repro.zip
2. Run dotnet publish -r win-x64 -c Release /p:PublishSingleFile=true /p:PublishTrimmed=true

Result

C:\Program Files\dotnet\sdk\5.0.100-preview.5.20258.6\Sdks\Microsoft.NET.Sdk\targets\Microsoft.NET.Publish.targets(962,5): error MSB4018: The "GenerateBundle" task failed unexpectedly. [C:\repro\repro.csproj]
C:\Program Files\dotnet\sdk\5.0.100-preview.5.20258.6\Sdks\Microsoft.NET.Sdk\targets\Microsoft.NET.Publish.targets(962,5): error MSB4018: System.ArgumentException: Invalid input specification: Found multiple entries with the same BundleRelativePath [C:\repro\repro.csproj]
C:\Program Files\dotnet\sdk\5.0.100-preview.5.20258.6\Sdks\Microsoft.NET.Sdk\targets\Microsoft.NET.Publish.targets(962,5): error MSB4018:    at Microsoft.NET.HostModel.Bundle.Bundler.GenerateBundle(IReadOnlyList`1 fileSpecs) [C:\repro\repro.csproj]

.csproj file for reference:

<Project Sdk="Microsoft.NET.Sdk">

  <PropertyGroup>
    <OutputType>Exe</OutputType>
    <TargetFramework>netcoreapp3.1</TargetFramework>
    <RootNamespace>log_import</RootNamespace>
  </PropertyGroup>

  <ItemGroup>
    <Reference Include="Kaitai.Struct.Runtime">
      <HintPath>Kaitai.Struct.Runtime.dll</HintPath>
    </Reference>
  </ItemGroup>

  <ItemGroup>
    <None Update="Kaitai.Struct.Runtime.dll">
      <CopyToOutputDirectory>PreserveNewest</CopyToOutputDirectory>
    </None>
  </ItemGroup>

</Project>

The error is due to the last item group. The last item group should just be ignored. The point is that the entry is relevant when developing the project, up until you decide to publish it.

Tagging subscribers to this area: @safern, @ViktorHofer
Notify danmosemsft if you want to be subscribed.

Tagging subscribers to this area: @swaroop-sridhar
Notify danmosemsft if you want to be subscribed.

[swaroop-sridhar]

In this project, due to

  <PropertyGroup>
    <OutputType>Exe</OutputType>
    <TargetFramework>netcoreapp3.1</TargetFramework>
    <RootNamespace>log_import</RootNamespace>
  </PropertyGroup>

  <ItemGroup>
    <Reference Include="Kaitai.Struct.Runtime">
      <HintPath>Kaitai.Struct.Runtime.dll</HintPath>
    </Reference>
  </ItemGroup>

ResolvedFileToPublish contains duplicate entries of Kaitai.Struct.Runtime.dll from
ReferenceCopyLocalPaths and _ThisProjectItemsToCopyToOutputDirectory.

    D:\test\repro\repro\Kaitai.Struct.Runtime.dll
                                   CopyLocal=true
                                   CopyToPublishDirectory=PreserveNewest
                                   DestinationSubPath=Kaitai.Struct.Runtime.dll
                                   FusionName=Kaitai.Struct.Runtime, Version=0.0.0.0, Culture=neutral, PublicKeyToken=null
                                   HintPath=Kaitai.Struct.Runtime.dll
                                   ImageRuntime=v4.0.30319
                                   OriginalItemSpec=Kaitai.Struct.Runtime
                                   ReferenceSourceTarget=ResolveAssemblyReference
                                   RelativePath=Kaitai.Struct.Runtime.dll
                                   ResolvedFrom={CandidateAssemblyFiles}
                                   Version=

A normal publish ignores this error, and possibly copies Kaitai.Struct.Runtime.dll twice to the output directory. During single-file publish, the duplicate input in _FilesToBundle is detected, and flagged as an error.

The single-file bundler can recognize that the input list contains the same file (same source and destination paths) and remove the duplicate. The error check is in place to detect the case where we have duplicate entries with different source paths.

However, I think it is better if the SDK removes the duplicates.

@dsplaisted @wli3

[Imperatorn]

Status?

[sfoslund]

Fixed in .NET 6 with #14020