- 
                Notifications
    
You must be signed in to change notification settings  - Fork 5.2k
 
[browser][MT] WebSocket thread affinity & server initiated close #96618
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
          
     Merged
      
      
    Conversation
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
    | 
           Tagging subscribers to 'arch-wasm': @lewing Issue Details
 
  | 
    
  This was referenced Jan 8, 2024 
      
| 
           /azp run runtime-wasm  | 
    
| 
          
Azure Pipelines successfully started running 1 pipeline(s). | 
    
| 
           /azp run runtime-wasm  | 
    
| 
          
Azure Pipelines successfully started running 1 pipeline(s). | 
    
7ca1743    to
    b32b41a      
    Compare
  
    b32b41a    to
    524ea30      
    Compare
  
    | 
           /azp run runtime-wasm  | 
    
| 
          
Azure Pipelines successfully started running 1 pipeline(s). | 
    
…ockets/BrowserWebSockets/BrowserInterop.cs Co-authored-by: Marek Fišera <[email protected]>
…ockets/BrowserWebSockets/BrowserInterop.cs Co-authored-by: Marek Fišera <[email protected]>
              
                    maraf
  
              
              approved these changes
              
                  
                    Jan 15, 2024 
                  
              
              
            
            
| 
           /azp run runtime-wasm  | 
    
| 
          
Azure Pipelines successfully started running 1 pipeline(s). | 
    
| 
           /azp run runtime-wasm  | 
    
| 
          
Azure Pipelines successfully started running 1 pipeline(s). | 
    
  This was referenced Jan 15, 2024 
      
     Closed
  
| 
           /azp run runtime-wasm  | 
    
| 
          
Azure Pipelines successfully started running 1 pipeline(s). | 
    
| 
           /azp run runtime-wasm  | 
    
| 
          
Azure Pipelines successfully started running 1 pipeline(s). | 
    
| 
           /azp run runtime-wasm  | 
    
| 
          
Azure Pipelines successfully started running 1 pipeline(s). | 
    
  This was referenced Jan 16, 2024 
      
  This was referenced Jan 17, 2024 
      
    
  tmds 
      pushed a commit
        to tmds/runtime
      that referenced
      this pull request
    
      Jan 23, 2024 
    
    
      
  
    
      
    
  
…net#96618) Co-authored-by: Marek Fišera <[email protected]> Co-authored-by: Katelyn Gadd <[email protected]>
  
      Sign up for free
      to subscribe to this conversation on GitHub.
      Already have an account?
      Sign in.
  
      Labels
      
    arch-wasm
  WebAssembly architecture 
  
    area-System.Runtime.InteropServices.JavaScript
  
    os-browser
  Browser variant of arch-wasm 
  Add this suggestion to a batch that can be applied as a single commit.
  This suggestion is invalid because no changes were made to the code.
  Suggestions cannot be applied while the pull request is closed.
  Suggestions cannot be applied while viewing a subset of changes.
  Only one suggestion per line can be applied in a batch.
  Add this suggestion to a batch that can be applied as a single commit.
  Applying suggestions on deleted lines is not supported.
  You must change the existing code in this line in order to create a valid suggestion.
  Outdated suggestions cannot be applied.
  This suggestion has been applied or marked resolved.
  Suggestions cannot be applied from pending reviews.
  Suggestions cannot be applied on multi-line comments.
  Suggestions cannot be applied while the pull request is queued to merge.
  Suggestion cannot be applied right now. Please check back later.
  
    
  
    
BrowserWebSocketnow uses automatic dispatch to correct thread viaJSSynchronizationContext&JSProxyContext& JS object affinityonClosedevent doesn't call back to C#CloseReceivedandCloseSentstatesCloseAsync_ServerInitiatedClose_SuccessCloseOutputAsync_ServerInitiated_CanReceiveSystem.Net.WebSockets.Client.Testsnow also run xunit on thread pool in MTWebWorkerTestFixes #65796
Fixes #96173
Contributes to #96359
With partial/loose backport for Net8 #97002