Fix potential NREs in ConfigurationBindingGenerator #96078
Merged
+2
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The TypeParseInfo.BinderInvocation is a nullable property. If it happens to be null, these two places will throw a null ref. .NET Aspire is reusing this code to generate JSON schemas for appsettings.json files. See dotnet/aspire#1383. The plan is to keep this in sync using automated PRs to dotnet/aspire when the dotnet/runtime code is updated. (dotnet/aspire#1424). Contributing this fix back so these two code bases can stay in sync.
|
Tagging subscribers to this area: @dotnet/area-extensions-configuration Issue DetailsThe TypeParseInfo.BinderInvocation is a nullable property. If it happens to be null, these two places will throw a null ref. .NET Aspire is reusing this code to generate JSON schemas for appsettings.json files. See dotnet/aspire#1383. The plan is to keep this in sync using automated PRs to dotnet/aspire when the dotnet/runtime code is updated. (dotnet/aspire#1424). Contributing this fix back so these two code bases can stay in sync.
|
ghost
assigned
tarekgh
approved these changes
Dec 19, 2023
tarekgh
added
the
source-generator
stephentoub
approved these changes
Jan 2, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The TypeParseInfo.BinderInvocation is a nullable property. If it happens to be null, these two places will throw a null ref.
.NET Aspire is reusing this code to generate JSON schemas for appsettings.json files. See dotnet/aspire#1383. The plan is to keep this in sync using automated PRs to dotnet/aspire when the dotnet/runtime code is updated. (dotnet/aspire#1424). Contributing this fix back so these two code bases can stay in sync.