[wasm] WBT: Use project ids that are safe for use as identifiers #89945
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For every test project, a random id is used which is `Path.GetRandomFileName()`. In some cases this `id` gets used in a generated C/C# source file, and that can cause failures. For example the following fails with: ``` blz_checkfingerprinting_Release_zqkzgkui.ref/Program.cs(3,48): error CS1001: Identifier expected [/root/helix/work/workitem/e/wbt/blz_checkfingerprinting_Release_zqkzgkui.ref/blz_checkfingerprinting_Release_zqkzgkui.ref.csproj] blz_checkfingerprinting_Release_zqkzgkui.ref/Program.cs(3,48): error CS1002: ; expected [/root/helix/work/workitem/e/wbt/blz_checkfingerprinting_Release_zqkzgkui.ref/blz_checkfingerprinting_Release_zqkzgkui.ref.csproj] blz_checkfingerprinting_Release_zqkzgkui.ref/Program.cs(3,51): error CS1031: Type expected [/root/helix/work/workitem/e/wbt/blz_checkfingerprinting_Release_zqkzgkui.ref/blz_checkfingerprinting_Release_zqkzgkui.ref.csproj] ``` because the id, `blz_checkfingerprinting_Release_zqkzgkui.ref`, was used as a namespace (line 3). ``` using Microsoft.AspNetCore.Components.Web; using Microsoft.AspNetCore.Components.WebAssembly.Hosting; using blz_checkfingerprinting_Release_zqkzgkui.ref; ``` Fix up the generated random ids to make them safer. The code is taken from `WasmAppBuilder/ManagedToNativeGenerator.cs`. Fixes dotnet#86533 .
|
Tagging subscribers to 'arch-wasm': @lewing Issue DetailsFor every test project, a random id is used which is For example the following fails with: because the id, Fix up the generated random ids to make them safer. The code is taken Fixes #86533 .
|
ghost
added
the
pavelsavara
approved these changes
Aug 3, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For every test project, a random id is used which is
Path.GetRandomFileName(). In some cases thisidgets used in agenerated C/C# source file, and that can cause failures.
For example the following fails with:
because the id,
blz_checkfingerprinting_Release_zqkzgkui.ref, was usedas a namespace (line 3).
Fix up the generated random ids to make them safer. The code is taken
from
WasmAppBuilder/ManagedToNativeGenerator.cs.Fixes #86533 .