Share SourceWriter between JSON & config binding generators #89150
Conversation
|
Tagging subscribers to this area: @dotnet/area-extensions-configuration Issue DetailsFixes #88918. FYI @tannergooding @ericstj @jasper-d @martincostello @vcsjones @lateralusX. The writer used for the JSON generator has the correct right line-ending behavior.
|
layomia
force-pushed
the
binder-gen-sourcewriter
branch
3 times, most recently
from
b3162e0 to
65c718f
Compare
layomia
force-pushed
the
binder-gen-sourcewriter
branch
from
65c718f to
9fd0a7a
Compare
...braries/Microsoft.Extensions.Configuration.Binder/gen/Helpers/Emitter/ConfigurationBinder.cs
Outdated
Show resolved
Hide resolved
src/libraries/Microsoft.Extensions.Configuration.Binder/gen/Helpers/Emitter/Helpers.cs
Outdated
Show resolved
Hide resolved
src/libraries/Common/tests/TestUtilities/System/LineEndingsHelper.cs
Outdated
Show resolved
Hide resolved
src/libraries/Common/tests/TestUtilities/System/LineEndingsHelper.cs
Outdated
Show resolved
Hide resolved
layomia
force-pushed
the
binder-gen-sourcewriter
branch
from
b1c8e64 to
5e37570
Compare
|
/backport to release/8.0-preview7 |
|
Started backporting to release/8.0-preview7: https://github.com/dotnet/runtime/actions/runs/5602367197 |
|
Shouldn't this be merged before initiating a backport PR? |
We're close on time -- it's fine to merge in parallel so long as we squash the commits in release. It does mean that both PRs need to be kept in sync, but right now we're ready to merge and just waiting for the validation build to complete. Assuming both are green we save a couple hours by doing it parallel. |
|
Build failure appears unrelated. |
ghost
locked as resolved and limited conversation to collaborators
3 participants
Fixes #88918. FYI @tannergooding @ericstj @jasper-d @martincostello @vcsjones @lateralusX.
The writer used for the JSON generator has the correct right line-ending behavior.