Add SocketsHttpHandler connection metrics #88893
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tagging subscribers to this area: @dotnet/ncl Issue DetailsCloses #84978 Implements the following counters (final names TBD):
Unlike the description from #84978, I dropped the Merge conflicts with #88853 are expected.
|
|
/azp run runtime-libraries-coreclr outerloop |
|
Azure Pipelines successfully started running 1 pipeline(s). |
This was referenced Jul 14, 2023
Closed
antonfirsov
approved these changes
Jul 14, 2023
...ries/System.Net.Http/src/System/Net/Http/SocketsHttpHandler/Metrics/ConnectionMetricsInfo.cs
Outdated
Show resolved
Hide resolved
...ries/System.Net.Http/src/System/Net/Http/SocketsHttpHandler/Metrics/ConnectionMetricsInfo.cs
Show resolved
Hide resolved
src/libraries/System.Net.Http/src/System/Net/Http/SocketsHttpHandler/HttpConnectionPool.cs
Outdated
Show resolved
Hide resolved
...ries/System.Net.Http/src/System/Net/Http/SocketsHttpHandler/Metrics/ConnectionMetricsInfo.cs
Outdated
Show resolved
Hide resolved
src/libraries/System.Net.Http/src/System/Net/Http/SocketsHttpHandler/Http3Connection.cs
Show resolved
Hide resolved
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #84978
Implements the following counters (final names TBD):
http-client-current-connectionshttp-client-current-idle-connectionshttp-client-connection-durationUnlike the description from #84978, I dropped the
reasontag fromhttp-client-connection-durationas it feels out of place on the duration counter, and it's not clear what values we'd want to report.Merge conflicts with #88853 are expected.