Block "Convert To LibraryImport" in more unsupported cases #87503
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jkoritzinsky
added
area-System.Runtime.InteropServices
source-generator
jkoritzinsky
requested review from
AaronRobinsonMSFT,
elinor-fung and
jtschuster
ghost
assigned
|
Tagging subscribers to this area: @dotnet/interop-contrib Issue DetailsBlock "Convert to LibraryImport" in cases where the user has specified
|
jtschuster
reviewed
Jun 13, 2023
...ntime.InteropServices/gen/LibraryImportGenerator/Analyzers/ConvertToLibraryImportAnalyzer.cs
Show resolved
Hide resolved
This was referenced Jun 13, 2023
stephentoub
reviewed
Jun 22, 2023
...ntime.InteropServices/gen/LibraryImportGenerator/Analyzers/ConvertToLibraryImportAnalyzer.cs
Outdated
Show resolved
Hide resolved
stephentoub
reviewed
Jun 22, 2023
...ntime.InteropServices/gen/LibraryImportGenerator/Analyzers/ConvertToLibraryImportAnalyzer.cs
Show resolved
Hide resolved
stephentoub
reviewed
Jun 22, 2023
...ntime.InteropServices/gen/LibraryImportGenerator/Analyzers/ConvertToLibraryImportAnalyzer.cs
Show resolved
Hide resolved
stephentoub
approved these changes
Jun 22, 2023
3 tasks
|
Failures are all unrelated. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Block "Convert to LibraryImport" in cases where the user has specified
BestFitMappingorThrowUnmappableCharin settings other than the one configurationLibraryImportsupports. Also block__arglistvarargs as we don't support that inLibraryImporteither.Fixes #79159