Warn when user code casts between runtime-based COM interop types and source-generated COM interop types #87425
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… source-generated COM interop types.
|
Tagging subscribers to this area: @dotnet/interop-contrib Issue DetailsWarn for these casts that will always fail. Contributes to #87350 (first item on the task list). Also fix one case of this that I missed when transitioning System.Transactions.Local (which proves that this analyzer is useful).
|
jkoritzinsky
requested review from
AaronRobinsonMSFT,
elinor-fung and
jtschuster
jtschuster
approved these changes
Jun 12, 2023
This was referenced Jun 13, 2023
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Warn for these casts that will always fail. Contributes to #87350 (first item on the task list).
Also fix one case of this that I missed when transitioning System.Transactions.Local (which proves that this analyzer is useful).