Skip to content

[browser] make cwraps more conditional #87274

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Jun 19, 2023
Merged

[browser] make cwraps more conditional #87274

merged 6 commits into from
Jun 19, 2023

Conversation

@pavelsavara
Copy link
Member

To address feedback at #85919 (comment)

@pavelsavara pavelsavara added this to the 8.0.0 milestone Jun 8, 2023
@pavelsavara pavelsavara self-assigned this Jun 8, 2023
@ghost
Copy link

ghost commented Jun 8, 2023

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

Issue Details

To address feedback at #85919 (comment)

Author: pavelsavara
Assignees: pavelsavara
Labels:

arch-wasm, area-System.Runtime.InteropServices.JavaScript
Milestone: 8.0.0

kg
kg reviewed Jun 8, 2023
View reviewed changes
kg
kg reviewed Jun 8, 2023
View reviewed changes
kg
kg reviewed Jun 8, 2023
View reviewed changes
@pavelsavara pavelsavara marked this pull request as ready for review June 8, 2023 16:56
@build-analysis build-analysis bot mentioned this pull request Jun 8, 2023
Closed
@build-analysis build-analysis bot mentioned this pull request Jun 12, 2023
Closed
radical
radical reviewed Jun 12, 2023
View reviewed changes
radical
radical reviewed Jun 12, 2023
View reviewed changes
@pavelsavara
Copy link
Member Author

CI failures are #87414

@pavelsavara pavelsavara merged commit 3386b86 into dotnet:main Jun 19, 2023
@ghost ghost locked as resolved and limited conversation to collaborators Jul 19, 2023
@pavelsavara pavelsavara deleted the browser_conditional_cwraps branch September 2, 2024 15:30
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@radical radical radical left review comments

@kg kg kg approved these changes

@lewing lewing Awaiting requested review from lewing lewing is a code owner

Assignees

@pavelsavara pavelsavara

Labels

arch-wasm WebAssembly architecture area-System.Runtime.InteropServices.JavaScript

Projects

None yet

Milestone

8.0.0

Development

Successfully merging this pull request may close these issues.

3 participants

@pavelsavara @radical @kg